Page MenuHomeSoftware Heritage

loader: Fix parsing of last dumped revision
ClosedPublic

Authored by anlambert on Jan 5 2022, 1:12 PM.

Details

Summary

svnrdump can output multiple error messages so we need to iterate
in reverse order on stderr output until finding a line that starts
with "* Dumped revision".

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
fix-last-dumped-revision-parsing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25824
Build 40361: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40360: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6879 (id=24943)

Rebasing onto 196c9d596b...

Current branch diff-target is up to date.
Changes applied before test
commit 886e2683bb2c68af6b956fc30cb869c4c860ae6f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 4 17:48:28 2022 +0100

    loader: Fix parsing of last dumped revision
    
    svnrdump can output multiple error messages so we need to iterate
    in reverse order on stderr output until finding a line that starts
    with "* Dumped revision".

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/217/ for more details.

This revision is now accepted and ready to land.Jan 5 2022, 3:18 PM

Build is green

Patch application report for D6879 (id=24953)

Rebasing onto 27df073594...

Current branch diff-target is up to date.
Changes applied before test
commit 1b13c5c19ef36528a9a005cbadc427cde3a10add
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 4 17:48:28 2022 +0100

    loader: Fix parsing of last dumped revision
    
    svnrdump can output multiple error messages so we need to iterate
    in reverse order on stderr output until finding a line that starts
    with "* Dumped revision".

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/221/ for more details.