Differential D6818

Move the 'error_reporter' config entry in a dedicated 'replayer' section
ClosedPublic
Actions

Authored by douardda on Dec 9 2021, 4:56 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDOBJSRPLa2d1aa994400: Move the 'error_reporter' config entry in a dedicated 'replayer' section

Summary

and improve the documentation of the replayer command.

Diff Detail

Repository

rDOBJSRPL Content replayer

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 25550
Build 39944: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39943: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,016 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.replayer.tests.test_cli::test_replay_content objstorages = {'dst': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a23278>, 'src': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a23208>} kafka_prefix = 'exsniziyjq', kafka_consumer_group = 'test-consumer-exsniziyjq' kafka_server = '127.0.0.1:50245'
	17 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.replayer.tests.test_cli::test_replay_content_check_dst[False-10-0] objstorages = {'dst': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a183c8>, 'src': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a18320>} kafka_prefix = 'dpfezgismq', kafka_consumer_group = 'test-consumer-dpfezgismq' kafka_server = '127.0.0.1:50245', check_dst = False, expected_copied = 10
	18 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.replayer.tests.test_cli::test_replay_content_check_dst[True-5-5] objstorages = {'dst': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a183c8>, 'src': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a18320>} kafka_prefix = 'eucinmiaih', kafka_consumer_group = 'test-consumer-eucinmiaih' kafka_server = '127.0.0.1:50245', check_dst = True, expected_copied = 5
	155 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.replayer.tests.test_cli::test_replay_content_check_dst_retry objstorages = {'dst': <swh.objstorage.replayer.tests.test_cli.FlakyObjStorage object at 0x7f909bff12e8>, 'src': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a185f8>} kafka_prefix = 'gbqvlmlsts', kafka_consumer_group = 'test-consumer-gbqvlmlsts' kafka_server = '127.0.0.1:50245', monkeypatch_retry_sleep = None
	17 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.objstorage.replayer.tests.test_cli::test_replay_content_exclude objstorages = {'dst': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a18390>, 'src': <swh.objstorage.backends.in_memory.InMemoryObjStorage object at 0x7f90a4a181d0>} kafka_prefix = 'izvczznrro', kafka_consumer_group = 'test-consumer-izvczznrro' kafka_server = '127.0.0.1:50245'
		View Full Test Results (9 Failed · 6 Passed)

Event Timeline

douardda created this revision.Dec 9 2021, 4:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2021, 4:56 PM

Build has FAILED

Patch application report for D6818 (id=24697)

Rebasing onto 86b8509fc2...

Current branch diff-target is up to date.

Changes applied before test

commit eb9e45cec1640d4b4656a5f11a4bbfb7f46c5868
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Dec 9 16:53:16 2021 +0100

    Move the 'error_reporter' config entry in a dedicated 'replayer' section
    
    and improve the documentation of the replayer command.

Link to build: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/26/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/26/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2021, 4:58 PM

Harbormaster failed remote builds in B25550: Diff 24697!

fix the code and tests

Build is green

Patch application report for D6818 (id=24703)

Rebasing onto 86b8509fc2...

Current branch diff-target is up to date.

Changes applied before test

commit 4c2912ccb506d8fe825d80fd2c84d1bce6b982ec
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Dec 9 16:53:16 2021 +0100

    Move the 'error_reporter' config entry in a dedicated 'replayer' section
    
    and improve the documentation of the replayer command.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/27/ for more details.

Harbormaster completed remote builds in B25556: Diff 24703.Dec 9 2021, 5:24 PM

douardda requested review of this revision.Dec 9 2021, 5:24 PM

vlorentz added a subscriber: vlorentz.Dec 9 2021, 5:47 PM

vlorentz added inline comments.

swh/objstorage/replayer/cli.py
85–95	is that indented enough for Sphinx?
swh/objstorage/replayer/tests/test_cli.py
67–68 ↗	(On Diff #24703)	the conditional isn't needed

I assume you'll take care of val's remarks ;)

This revision is now accepted and ready to land.Dec 14 2021, 5:53 PM

douardda added inline comments.Jan 4 2022, 2:46 PM

swh/objstorage/replayer/cli.py
85–95	Should be yes (not checked the result however)
swh/objstorage/replayer/tests/test_cli.py
67–68 ↗	(On Diff #24703)	indeed, thanks

vlorentz' comment + update copyright timestamps

Build is green

Patch application report for D6818 (id=24927)

Rebasing onto fa5dfe0382...

Current branch diff-target is up to date.

Changes applied before test

commit a2d1aa994400b23ce47b920266bf8cfd1810c43a
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Dec 9 16:53:16 2021 +0100

    Move the 'error_reporter' config entry in a dedicated 'replayer' section
    
    and improve the documentation of the replayer command.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/28/ for more details.

Harbormaster completed remote builds in B25798: Diff 24927.Jan 4 2022, 2:51 PM

douardda added inline comments.Jan 4 2022, 2:52 PM