Page MenuHomeSoftware Heritage

Move the 'error_reporter' config entry in a dedicated 'replayer' section
ClosedPublic

Authored by douardda on Dec 9 2021, 4:56 PM.

Details

Summary

and improve the documentation of the replayer command.

Diff Detail

Repository
rDOBJSRPL Content replayer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6818 (id=24697)

Rebasing onto 86b8509fc2...

Current branch diff-target is up to date.
Changes applied before test
commit eb9e45cec1640d4b4656a5f11a4bbfb7f46c5868
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Dec 9 16:53:16 2021 +0100

    Move the 'error_reporter' config entry in a dedicated 'replayer' section
    
    and improve the documentation of the replayer command.

Link to build: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/26/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/26/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2021, 4:58 PM
Harbormaster failed remote builds in B25550: Diff 24697!

Build is green

Patch application report for D6818 (id=24703)

Rebasing onto 86b8509fc2...

Current branch diff-target is up to date.
Changes applied before test
commit 4c2912ccb506d8fe825d80fd2c84d1bce6b982ec
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Dec 9 16:53:16 2021 +0100

    Move the 'error_reporter' config entry in a dedicated 'replayer' section
    
    and improve the documentation of the replayer command.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/27/ for more details.

vlorentz added inline comments.
swh/objstorage/replayer/cli.py
85–95

is that indented enough for Sphinx?

swh/objstorage/replayer/tests/test_cli.py
67–68

the conditional isn't needed

ardumont added a subscriber: ardumont.

I assume you'll take care of val's remarks ;)

This revision is now accepted and ready to land.Dec 14 2021, 5:53 PM
swh/objstorage/replayer/cli.py
85–95

Should be yes (not checked the result however)

swh/objstorage/replayer/tests/test_cli.py
67–68

indeed, thanks

vlorentz' comment + update copyright timestamps

Build is green

Patch application report for D6818 (id=24927)

Rebasing onto fa5dfe0382...

Current branch diff-target is up to date.
Changes applied before test
commit a2d1aa994400b23ce47b920266bf8cfd1810c43a
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Dec 9 16:53:16 2021 +0100

    Move the 'error_reporter' config entry in a dedicated 'replayer' section
    
    and improve the documentation of the replayer command.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/28/ for more details.

swh/objstorage/replayer/cli.py
85–95