This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.
That commit unnecessarily restricted dir entries to be valid UTF-8.
This diffs goes back to generating arbitrary bytes, and D6788
will restrict it to arbitrary bytes without /.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDMOD4803d786d911: Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25480 Build 39829: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 39828: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 2,973 ms | Jenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.tests.test_model::test_repr @given(strategies.objects())
> def test_repr(objtype_and_obj):
"""Checks every model object has a working repr(), and that it can be eval()uated
| |
| 3 ms | Jenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.merkle::swh.model.merkle.deep_update | |
| 1 ms | Jenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.swhids::swh.model.swhids.CoreSWHID | |
| 1 ms | Jenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.swhids::swh.model.swhids.ExtendedSWHID | |
| 1 ms | Jenkins > .tox.py3-full.lib.python3.7.site-packages.swh.model.swhids::swh.model.swhids.QualifiedSWHID | |
| View Full Test Results (1 Failed · 831 Passed · 2 Skipped) |
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D6787 (id=24621)
Rebasing onto c525484e47...
Current branch diff-target is up to date.
Changes applied before test
commit a2f4c79958bec48b21dcf7e0adf2f2dc78eac1d3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Dec 8 12:22:01 2021 +0100
Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/416/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/416/console
Comment Actions
Build is green
Patch application report for D6787 (id=24630)
Rebasing onto f6e0a289ef...
Current branch diff-target is up to date.
Changes applied before test
commit 4803d786d911848600ccab531071fbbbbe499aaa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Dec 8 12:22:01 2021 +0100
Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/420/ for more details.