Differential D669

storage: Open content_fossology_license_get_range endpoint
ClosedPublic
Actions

Authored by ardumont on Nov 17 2018, 9:37 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDCIDX932471b52122: storage: Open content_fossology_license_get_range endpoint

Summary

Related T991

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 17 2018, 9:37 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/49/ for more details.

Harbormaster completed remote builds in B2436: Diff 2111.Nov 17 2018, 9:41 AM

ardumont added a child revision: D670: fossology_license: Open new range indexer.Nov 17 2018, 9:44 AM

vlorentz requested changes to this revision.Nov 17 2018, 1:19 PM

vlorentz added inline comments.

swh/indexer/storage/__init__.py
478	Return the licenses as well? It avoids doing a bunch of extra queries afterward
swh/indexer/tests/storage/__init__.py
138	You might want to test with more than one license too

This revision now requires changes to proceed.Nov 17 2018, 1:19 PM

I disagree with the required changes.

At worst, there might be some factorization in the tests (like i did in the next diffs).
(I'm willing to do it but not right now.)
Other than that, it's ready.

swh/indexer/storage/__init__.py
478	It's not intended to be used for that. Only the presence is needed. When it will be needed, it will be adapted.
swh/indexer/tests/storage/__init__.py
138	We do not need to ;)

vlorentz accepted this revision.Nov 17 2018, 7:56 PM

This revision is now accepted and ready to land.Nov 17 2018, 7:56 PM

Closed by commit rDCIDX932471b52122: storage: Open content_fossology_license_get_range endpoint (authored by ardumont). · Explain WhyNov 19 2018, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

storage/

29 lines

2 lines

tests/

storage/

65 lines

test_storage.py

81 lines

Diff 2115

swh/indexer/storage/init.py

Loading...

swh/indexer/storage/db.py

Loading...

swh/indexer/tests/storage/init.py

Loading...

swh/indexer/tests/storage/test_storage.py

Loading...