Page MenuHomeSoftware Heritage

tests: Add Ctags Indexer tests
ClosedPublic

Authored by ardumont on Nov 17 2018, 9:48 AM.

Details

Summary

Also add missing test scenarii for wrongly initialized indexers.

Depends on D670

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

because stacked diff does not build yet.

vlorentz added inline comments.
swh/indexer/tests/test_ctags.py
35–58 ↗(On Diff #2113)

same comment as on D670

68–93 ↗(On Diff #2113)

same

This revision now requires changes to proceed.Nov 17 2018, 1:32 PM

While i appreciate you taking your time off to answer immediately (that was for monday ;)...
Like i said in D670, the require change directly without discussion possible i do not... (i disagree with your remarks in the previous diffs but that comes too late now).
That's focusing way too much on the negative sides instead of the positive ones (fixing coverage to ease maintenance, avoiding duplication for the next one).

In general, I think we need to discuss that (as a team).

Also, in that case, the urgency is to deploy the new indexers to fix that part of the production...
(which has been broken since i tried to deploy the metadata indexers, around at least 1 week already).

Cheers,

This revision is now accepted and ready to land.Nov 17 2018, 8:00 PM
This revision was automatically updated to reflect the committed changes.