allows to choose replayed object types from the cli.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDSTO55eed77b519c: Add a --type option to 'swh storage replay'
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- reporter
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 24753 Build 38643: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 38642: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D6569 (id=23871)
Rebasing onto 49a932c989...
Current branch diff-target is up to date.
Changes applied before test
commit 74dbb2b0b148750de272f2f1a523c72b6b2e1365
Author: David Douard <david.douard@sdfa3.org>
Date: Tue Oct 26 16:38:26 2021 +0200
Add a --type option to 'swh storage replay'
allows to choose replayed object types from the cli.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1463/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1463/console
Comment Actions
Build is green
Patch application report for D6569 (id=23879)
Rebasing onto 49a932c989...
Current branch diff-target is up to date.
Changes applied before test
commit 04ba5910d53c8e9eb55a4bc2396840f9a47a5ac5
Author: David Douard <david.douard@sdfa3.org>
Date: Tue Oct 26 16:38:26 2021 +0200
Add a --type option to 'swh storage replay'
allows to choose replayed object types from the cli.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1467/ for more details.
| swh/storage/cli.py | ||
|---|---|---|
| 168 | s/check/write/? | |
Comment Actions
Maybe it would be worth expanding the existing cli test for this flag?
| swh/storage/cli.py | ||
|---|---|---|
| 168 | or even replay | |
Comment Actions
Use a hardwritten list of accepted objects
instead of loading swh.s.replay in a cli module.
Add a test to check this list is consistent with replay.py
Comment Actions
Build is green
Patch application report for D6569 (id=24036)
Rebasing onto a5bfe5b514...
First, rewinding head to replay your work on top of it... Applying: Add a --type option to 'swh storage replay'
Changes applied before test
commit 227154ba34485fa07fbadf59a5f8aae7f8348f03
Author: David Douard <david.douard@sdfa3.org>
Date: Tue Oct 26 16:38:26 2021 +0200
Add a --type option to 'swh storage replay'
allows to choose replayed object types from the cli.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1480/ for more details.
Comment Actions
Build is green
Patch application report for D6569 (id=24085)
Rebasing onto 0262f1c191...
Current branch diff-target is up to date.
Changes applied before test
commit 55eed77b519c4c3fc22b95554afa3343e013a253
Author: David Douard <david.douard@sdfa3.org>
Date: Tue Oct 26 16:38:26 2021 +0200
Add a --type option to 'swh storage replay'
allows to choose replayed object types from the cli.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1486/ for more details.