Page MenuHomeSoftware Heritage
Differential D6564

Do call consumer.commit() even if not objects have been received
ClosedPublic
Actions

Authored by douardda on Oct 27 2021, 4:18 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Commits
rDJNL88054da89653: Do call consumer.commit() even if not objects have been received

Diff Detail

Event Timeline

douardda created this revision.Oct 27 2021, 4:18 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 27 2021, 4:18 PM
douardda added a child revision: D6565: Pass the object_type to JournalClient.value_serializer().Oct 27 2021, 4:19 PM
swh-public-ci added a comment.Oct 27 2021, 4:22 PM

Build is green

Patch application report for D6564 (id=23857)

Rebasing onto 95d945e46e...

Current branch diff-target is up to date.
Changes applied before test
commit 88054da89653d0e28e6600842eb9287db25b5244
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:14:17 2021 +0200

    Do call consumer.commit() even if not objects have been received

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/173/ for more details.

Harbormaster completed remote builds in B24740: Diff 23857.Oct 27 2021, 4:22 PM
douardda requested review of this revision.Oct 27 2021, 4:22 PM
ardumont added a subscriber: ardumont.Oct 27 2021, 5:17 PM

why if i may ask?

douardda added a comment.Oct 28 2021, 11:21 AM
In D6564#170522, @ardumont wrote:

why if i may ask?

Something we discussed with olasd some time ago, but I don't remember exactly the details. Should help having better offset status reported to kakfa.

vlorentz accepted this revision.Oct 28 2021, 11:36 AM
vlorentz added a subscriber: vlorentz.

"ok then"

This revision is now accepted and ready to land.Oct 28 2021, 11:36 AM
ardumont accepted this revision.Oct 28 2021, 11:37 AM

ok

Closed by commit rDJNL88054da89653: Do call consumer.commit() even if not objects have been received (authored by douardda). · Explain WhyOct 28 2021, 2:34 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDJNL88054da89653: Do call consumer.commit() even if not objects have been received.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
journal/
2 lines79%
Loading...

Diff 23857

View Options

swh/journal/client.py

Loading...
About · Developer information · Legal