Page MenuHomeSoftware Heritage

Do call consumer.commit() even if not objects have been received
ClosedPublic

Authored by douardda on Oct 27 2021, 4:18 PM.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6564 (id=23857)

Rebasing onto 95d945e46e...

Current branch diff-target is up to date.
Changes applied before test
commit 88054da89653d0e28e6600842eb9287db25b5244
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Oct 27 16:14:17 2021 +0200

    Do call consumer.commit() even if not objects have been received

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/173/ for more details.

why if i may ask?

Something we discussed with olasd some time ago, but I don't remember exactly the details. Should help having better offset status reported to kakfa.

This revision is now accepted and ready to land.Oct 28 2021, 11:36 AM