Differential D6461

tests: Turn snapshot* hypothesis strategies into pytest fixtures
ClosedPublic
Actions

Authored by anlambert on Oct 12 2021, 3:53 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3603: Replace stateful hypothesis strategies by pytest fixtures

Commits

rDWAPPSa91200cbe1e5: tests: Turn snapshot* hypothesis strategies into pytest fixtures

Summary

Related to T3603

Depends on D6460

Diff Detail

Repository

rDWAPPS Web applications

Branch

snapshot-strategies-to-pytest-fixtures

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24389
Build 38067: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38066: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 12 2021, 3:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 12 2021, 3:53 PM

Build is green

Patch application report for D6461 (id=23472)

Could not rebase; Attempt merge onto d7c16735a4...

Updating d7c16735..2b1374a5
Fast-forward
 swh/web/tests/api/test_apiresponse.py          |   3 -
 swh/web/tests/api/test_utils.py                |  46 +--
 swh/web/tests/api/views/test_content.py        |  12 -
 swh/web/tests/api/views/test_directory.py      |   7 -
 swh/web/tests/api/views/test_graph.py          |   6 +-
 swh/web/tests/api/views/test_identifiers.py    |  11 +-
 swh/web/tests/api/views/test_origin.py         |   5 +-
 swh/web/tests/api/views/test_release.py        |   6 -
 swh/web/tests/api/views/test_revision.py       |  13 +-
 swh/web/tests/api/views/test_snapshot.py       |  17 +-
 swh/web/tests/api/views/test_vault.py          |  14 +-
 swh/web/tests/browse/test_snapshot_context.py  |  39 +-
 swh/web/tests/browse/views/test_content.py     | 190 +++++-----
 swh/web/tests/browse/views/test_directory.py   |  67 ++--
 swh/web/tests/browse/views/test_identifiers.py |  20 --
 swh/web/tests/browse/views/test_origin.py      | 114 +++---
 swh/web/tests/browse/views/test_release.py     |  16 +-
 swh/web/tests/browse/views/test_revision.py    |  12 +-
 swh/web/tests/common/test_archive.py           |  81 +----
 swh/web/tests/common/test_identifiers.py       | 112 +++---
 swh/web/tests/common/test_middlewares.py       |   4 -
 swh/web/tests/common/test_origin_visits.py     |  21 +-
 swh/web/tests/conftest.py                      | 472 ++++++++++++++++++++++++-
 swh/web/tests/misc/test_badges.py              |  15 +-
 swh/web/tests/misc/test_iframe.py              |  13 +-
 swh/web/tests/strategies.py                    | 460 +-----------------------
 26 files changed, 776 insertions(+), 1000 deletions(-)

Changes applied before test

commit 2b1374a568892443f6d8a02e032185df8c3ed3c5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 15:52:31 2021 +0200

    tests: Turn snapshot* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 341454015ded898208886aff905c92634a6deefe
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 15:26:40 2021 +0200

    tests: Turn revision* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c4fed93688b1658684ee5792eb020272750f9de1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 14:08:49 2021 +0200

    tests: Turn release* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c2d10c90c3bd6f5fa3634fa456475c3fa92ae194
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 13:48:57 2021 +0200

    tests: Turn origin* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 81486f517526f7cb94e0ca2ed49433ebd7c3d1b3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 11:45:43 2021 +0200

    tests: Turn directory* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 23a8dc33453fdcf3fb0037ba1c0c76752d40c1c4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it feels a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1169/ for more details.

Harbormaster completed remote builds in B24389: Diff 23472.Oct 12 2021, 4:08 PM

anlambert requested review of this revision.Oct 12 2021, 4:08 PM

anlambert added a child revision: D6463: tests: Turn remaining hypothesis strategies into pytest fixtures.Oct 12 2021, 5:25 PM

vlorentz accepted this revision.Oct 13 2021, 3:40 PM

This revision is now accepted and ready to land.Oct 13 2021, 3:40 PM

Add missing tests_data parameter to snapshot_swhid fixture

Build is green

Patch application report for D6461 (id=23489)

Could not rebase; Attempt merge onto d7c16735a4...

Updating d7c16735..a91200cb
Fast-forward
 swh/web/tests/api/test_apiresponse.py          |   3 -
 swh/web/tests/api/test_utils.py                |  46 +--
 swh/web/tests/api/views/test_content.py        |  12 -
 swh/web/tests/api/views/test_directory.py      |   7 -
 swh/web/tests/api/views/test_graph.py          |   6 +-
 swh/web/tests/api/views/test_identifiers.py    |  11 +-
 swh/web/tests/api/views/test_origin.py         |   5 +-
 swh/web/tests/api/views/test_release.py        |   6 -
 swh/web/tests/api/views/test_revision.py       |  13 +-
 swh/web/tests/api/views/test_snapshot.py       |  17 +-
 swh/web/tests/api/views/test_vault.py          |  14 +-
 swh/web/tests/browse/test_snapshot_context.py  |  39 +-
 swh/web/tests/browse/views/test_content.py     | 190 +++++-----
 swh/web/tests/browse/views/test_directory.py   |  67 ++--
 swh/web/tests/browse/views/test_identifiers.py |  20 --
 swh/web/tests/browse/views/test_origin.py      | 114 +++---
 swh/web/tests/browse/views/test_release.py     |  16 +-
 swh/web/tests/browse/views/test_revision.py    |  12 +-
 swh/web/tests/common/test_archive.py           |  81 +----
 swh/web/tests/common/test_identifiers.py       | 112 +++---
 swh/web/tests/common/test_middlewares.py       |   4 -
 swh/web/tests/common/test_origin_visits.py     |  21 +-
 swh/web/tests/conftest.py                      | 472 ++++++++++++++++++++++++-
 swh/web/tests/misc/test_badges.py              |  15 +-
 swh/web/tests/misc/test_iframe.py              |  13 +-
 swh/web/tests/strategies.py                    | 460 +-----------------------
 26 files changed, 776 insertions(+), 1000 deletions(-)

Changes applied before test

commit a91200cbe1e57ead8351d6bb674e83f750e997d7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 15:52:31 2021 +0200

    tests: Turn snapshot* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 341454015ded898208886aff905c92634a6deefe
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 15:26:40 2021 +0200

    tests: Turn revision* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c4fed93688b1658684ee5792eb020272750f9de1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 14:08:49 2021 +0200

    tests: Turn release* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c2d10c90c3bd6f5fa3634fa456475c3fa92ae194
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 13:48:57 2021 +0200

    tests: Turn origin* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 81486f517526f7cb94e0ca2ed49433ebd7c3d1b3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 11:45:43 2021 +0200

    tests: Turn directory* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 23a8dc33453fdcf3fb0037ba1c0c76752d40c1c4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it feels a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1172/ for more details.

Harbormaster completed remote builds in B24402: Diff 23489.Oct 13 2021, 5:07 PM

Closed by commit rDWAPPSa91200cbe1e5: tests: Turn snapshot* hypothesis strategies into pytest fixtures (authored by anlambert). · Explain WhyOct 14 2021, 11:04 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSa91200cbe1e5: tests: Turn snapshot* hypothesis strategies into pytest fixtures.