Page MenuHomeSoftware Heritage

tests: Turn content* hypothesis strategies into pytest fixtures
ClosedPublic

Authored by anlambert on Mon, Oct 11, 4:59 PM.

Details

Summary

Using such hypothesis strategies have several drawbacks so let's
turn them into pytest fixtures as it seems a better way to do so.

Related to T3603

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6455 (id=23449)

Rebasing onto d7c16735a4...

First, rewinding head to replay your work on top of it...
Applying: tests: Turn content* hypothesis strategies into pytest fixtures
Changes applied before test
commit bbdcba43b9ef1f1c1d02d9eca332b261355c8623
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it seems a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1159/ for more details.

ardumont added a subscriber: ardumont.

lgtm

I suppose you'll align the other hypothesis strategies the same way in other diffs?

This revision is now accepted and ready to land.Mon, Oct 11, 5:36 PM

lgtm

I suppose you'll align the other hypothesis strategies the same way in other diffs?

Yes, I am doing this step by step to in order to have diffs with reasonable sizes.

Build is green

Patch application report for D6455 (id=23462)

Rebasing onto d7c16735a4...

Current branch diff-target is up to date.
Changes applied before test
commit 51317a52acb1b6a2624850ed02598da460310dc3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it seems a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1160/ for more details.

Build is green

Patch application report for D6455 (id=23463)

Rebasing onto d7c16735a4...

Current branch diff-target is up to date.
Changes applied before test
commit d2b9fa814f3600efc49c3f17033f70c7728d492d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it seems a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1161/ for more details.

Forgot to remove content_swhid strategy

Build is green

Patch application report for D6455 (id=23464)

Rebasing onto d7c16735a4...

Current branch diff-target is up to date.
Changes applied before test
commit 23a8dc33453fdcf3fb0037ba1c0c76752d40c1c4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it feels a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1162/ for more details.