Page MenuHomeSoftware Heritage
Differential D6455

tests: Turn content* hypothesis strategies into pytest fixtures
ClosedPublic
Actions

Authored by anlambert on Oct 11 2021, 4:59 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3603: Replace stateful hypothesis strategies by pytest fixtures
Commits
rDWAPPS23a8dc33453f: tests: Turn content* hypothesis strategies into pytest fixtures
Summary

Using such hypothesis strategies have several drawbacks so let's
turn them into pytest fixtures as it seems a better way to do so.

Related to T3603

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 11 2021, 4:59 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 11 2021, 4:59 PM
swh-public-ci added a comment.Oct 11 2021, 5:13 PM

Build is green

Patch application report for D6455 (id=23449)

Rebasing onto d7c16735a4...

First, rewinding head to replay your work on top of it...
Applying: tests: Turn content* hypothesis strategies into pytest fixtures
Changes applied before test
commit bbdcba43b9ef1f1c1d02d9eca332b261355c8623
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it seems a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1159/ for more details.

Harbormaster completed remote builds in B24366: Diff 23449.Oct 11 2021, 5:13 PM
anlambert requested review of this revision.Oct 11 2021, 5:13 PM
ardumont accepted this revision.Oct 11 2021, 5:36 PM
ardumont added a subscriber: ardumont.

lgtm

I suppose you'll align the other hypothesis strategies the same way in other diffs?

This revision is now accepted and ready to land.Oct 11 2021, 5:36 PM
anlambert added a comment.Oct 12 2021, 10:38 AM
In D6455#167506, @ardumont wrote:

lgtm

I suppose you'll align the other hypothesis strategies the same way in other diffs?

Yes, I am doing this step by step to in order to have diffs with reasonable sizes.

anlambert updated this revision to Diff 23462.Oct 12 2021, 10:54 AM

Rebase

anlambert updated this revision to Diff 23463.Oct 12 2021, 11:01 AM

Fix typo in function name

swh-public-ci added a comment.Oct 12 2021, 11:08 AM

Build is green

Patch application report for D6455 (id=23462)

Rebasing onto d7c16735a4...

Current branch diff-target is up to date.
Changes applied before test
commit 51317a52acb1b6a2624850ed02598da460310dc3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it seems a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1160/ for more details.

Harbormaster completed remote builds in B24379: Diff 23462.Oct 12 2021, 11:09 AM
swh-public-ci added a comment.Oct 12 2021, 11:16 AM

Build is green

Patch application report for D6455 (id=23463)

Rebasing onto d7c16735a4...

Current branch diff-target is up to date.
Changes applied before test
commit d2b9fa814f3600efc49c3f17033f70c7728d492d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it seems a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1161/ for more details.

Harbormaster completed remote builds in B24380: Diff 23463.Oct 12 2021, 11:16 AM
anlambert updated this revision to Diff 23464.Oct 12 2021, 11:27 AM

Forgot to remove content_swhid strategy

swh-public-ci added a comment.Oct 12 2021, 11:42 AM

Build is green

Patch application report for D6455 (id=23464)

Rebasing onto d7c16735a4...

Current branch diff-target is up to date.
Changes applied before test
commit 23a8dc33453fdcf3fb0037ba1c0c76752d40c1c4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it feels a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1162/ for more details.

Harbormaster completed remote builds in B24381: Diff 23464.Oct 12 2021, 11:42 AM
anlambert added a child revision: D6457: tests: Turn directory* hypothesis strategies into pytest fixtures.Oct 12 2021, 11:47 AM
Closed by commit rDWAPPS23a8dc33453f: tests: Turn content* hypothesis strategies into pytest fixtures (authored by anlambert). · Explain WhyOct 14 2021, 11:04 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS23a8dc33453f: tests: Turn content* hypothesis strategies into pytest fixtures.

Revision Contents
Changeset List

PathSize
swh/
web/
tests/
api/
4 lines
11 lines
views/
12 lines
9 lines
4 lines
4 lines
browse/
views/
142 lines
11 lines
common/
25 lines
8 lines
202 lines
misc/
2 lines
10 lines
151 lines

Diff 23499

View Options

swh/web/tests/api/test_apiresponse.py

Loading...
View Options

swh/web/tests/api/test_utils.py

Loading...
View Options

swh/web/tests/api/views/test_content.py

Loading...
View Options

swh/web/tests/api/views/test_identifiers.py

Loading...
View Options

swh/web/tests/api/views/test_release.py

Loading...
View Options

swh/web/tests/api/views/test_revision.py

Loading...
View Options

swh/web/tests/browse/views/test_content.py

Loading...
View Options

swh/web/tests/browse/views/test_identifiers.py

Loading...
View Options

swh/web/tests/common/test_archive.py

Loading...
View Options

swh/web/tests/common/test_identifiers.py

Loading...
View Options

swh/web/tests/conftest.py

Loading...
View Options

swh/web/tests/misc/test_badges.py

Loading...
View Options

swh/web/tests/misc/test_iframe.py

Loading...
View Options

swh/web/tests/strategies.py

Loading...
About · Developer information · Legal