Page MenuHomeSoftware Heritage

tests: Turn revision* hypothesis strategies into pytest fixtures
ClosedPublic

Authored by anlambert on Tue, Oct 12, 3:27 PM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6460 (id=23471)

Could not rebase; Attempt merge onto d7c16735a4...

Updating d7c16735..34145401
Fast-forward
 swh/web/tests/api/test_apiresponse.py          |   3 -
 swh/web/tests/api/test_utils.py                |  44 +--
 swh/web/tests/api/views/test_content.py        |  12 -
 swh/web/tests/api/views/test_directory.py      |   7 -
 swh/web/tests/api/views/test_graph.py          |   6 +-
 swh/web/tests/api/views/test_identifiers.py    |  12 +-
 swh/web/tests/api/views/test_origin.py         |   5 +-
 swh/web/tests/api/views/test_release.py        |   6 -
 swh/web/tests/api/views/test_revision.py       |  13 +-
 swh/web/tests/api/views/test_snapshot.py       |  13 +-
 swh/web/tests/api/views/test_vault.py          |  14 +-
 swh/web/tests/browse/test_snapshot_context.py  |  37 +-
 swh/web/tests/browse/views/test_content.py     | 190 +++++-----
 swh/web/tests/browse/views/test_directory.py   |  67 ++--
 swh/web/tests/browse/views/test_identifiers.py |  18 +-
 swh/web/tests/browse/views/test_origin.py      | 114 +++---
 swh/web/tests/browse/views/test_release.py     |  16 +-
 swh/web/tests/browse/views/test_revision.py    |  12 +-
 swh/web/tests/common/test_archive.py           |  79 +----
 swh/web/tests/common/test_identifiers.py       | 115 +++----
 swh/web/tests/common/test_origin_visits.py     |  21 +-
 swh/web/tests/conftest.py                      | 457 ++++++++++++++++++++++++-
 swh/web/tests/misc/test_badges.py              |  13 +-
 swh/web/tests/misc/test_iframe.py              |  13 +-
 swh/web/tests/strategies.py                    | 416 +---------------------
 25 files changed, 769 insertions(+), 934 deletions(-)
Changes applied before test
commit 341454015ded898208886aff905c92634a6deefe
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 15:26:40 2021 +0200

    tests: Turn revision* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c4fed93688b1658684ee5792eb020272750f9de1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 14:08:49 2021 +0200

    tests: Turn release* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c2d10c90c3bd6f5fa3634fa456475c3fa92ae194
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 13:48:57 2021 +0200

    tests: Turn origin* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 81486f517526f7cb94e0ca2ed49433ebd7c3d1b3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 11:45:43 2021 +0200

    tests: Turn directory* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 23a8dc33453fdcf3fb0037ba1c0c76752d40c1c4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it feels a better way to do so.
    
    Related to T3603

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1167/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1167/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 12, 3:42 PM
Harbormaster failed remote builds in B24388: Diff 23471!

Build is green

Patch application report for D6460 (id=23471)

Could not rebase; Attempt merge onto d7c16735a4...

Updating d7c16735..34145401
Fast-forward
 swh/web/tests/api/test_apiresponse.py          |   3 -
 swh/web/tests/api/test_utils.py                |  44 +--
 swh/web/tests/api/views/test_content.py        |  12 -
 swh/web/tests/api/views/test_directory.py      |   7 -
 swh/web/tests/api/views/test_graph.py          |   6 +-
 swh/web/tests/api/views/test_identifiers.py    |  12 +-
 swh/web/tests/api/views/test_origin.py         |   5 +-
 swh/web/tests/api/views/test_release.py        |   6 -
 swh/web/tests/api/views/test_revision.py       |  13 +-
 swh/web/tests/api/views/test_snapshot.py       |  13 +-
 swh/web/tests/api/views/test_vault.py          |  14 +-
 swh/web/tests/browse/test_snapshot_context.py  |  37 +-
 swh/web/tests/browse/views/test_content.py     | 190 +++++-----
 swh/web/tests/browse/views/test_directory.py   |  67 ++--
 swh/web/tests/browse/views/test_identifiers.py |  18 +-
 swh/web/tests/browse/views/test_origin.py      | 114 +++---
 swh/web/tests/browse/views/test_release.py     |  16 +-
 swh/web/tests/browse/views/test_revision.py    |  12 +-
 swh/web/tests/common/test_archive.py           |  79 +----
 swh/web/tests/common/test_identifiers.py       | 115 +++----
 swh/web/tests/common/test_origin_visits.py     |  21 +-
 swh/web/tests/conftest.py                      | 457 ++++++++++++++++++++++++-
 swh/web/tests/misc/test_badges.py              |  13 +-
 swh/web/tests/misc/test_iframe.py              |  13 +-
 swh/web/tests/strategies.py                    | 416 +---------------------
 25 files changed, 769 insertions(+), 934 deletions(-)
Changes applied before test
commit 341454015ded898208886aff905c92634a6deefe
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 15:26:40 2021 +0200

    tests: Turn revision* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c4fed93688b1658684ee5792eb020272750f9de1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 14:08:49 2021 +0200

    tests: Turn release* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit c2d10c90c3bd6f5fa3634fa456475c3fa92ae194
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 13:48:57 2021 +0200

    tests: Turn origin* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 81486f517526f7cb94e0ca2ed49433ebd7c3d1b3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 12 11:45:43 2021 +0200

    tests: Turn directory* hypothesis strategies into pytest fixtures
    
    Related to T3603

commit 23a8dc33453fdcf3fb0037ba1c0c76752d40c1c4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 11 15:17:58 2021 +0200

    tests: Turn content* hypothesis strategies into pytest fixtures
    
    Using such hypothesis strategies have several drawbacks so let's
    turn them into pytest fixtures as it feels a better way to do so.
    
    Related to T3603

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1168/ for more details.

This revision is now accepted and ready to land.Wed, Oct 13, 3:40 PM