Details
Details
- Reviewers
ardumont anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS25654a2764b6: directory-display: Show human-readable file sizes (KB, MB, ...).
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23462 Build 36609: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 36608: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6218 (id=22497)
Rebasing onto ec19895012...
Current branch diff-target is up to date.
Changes applied before test
commit 5d9075dc9eb09518ba9f74e4287c72821b0d8925
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Sep 8 17:21:16 2021 +0200
directory-display: Show human-readable file sizes (KB, MB, ...).
https://docs.djangoproject.com/en/3.2/ref/templates/builtins/#filesizeformatSee https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1097/ for more details.
Comment Actions
Looks good but filesizeformat is already used in many views implementation (grep for it).
I agree it is better to use it in template so we should remove their use in Python code before landing this.
Comment Actions
Build is green
Patch application report for D6218 (id=22515)
Rebasing onto 3d6abb9ae1...
Current branch diff-target is up to date.
Changes applied before test
commit 25654a2764b6428bcaf6228db059ab445da5ec05
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Sep 8 17:21:16 2021 +0200
directory-display: Show human-readable file sizes (KB, MB, ...).
https://docs.djangoproject.com/en/3.2/ref/templates/builtins/#filesizeformatSee https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1099/ for more details.