Differential D6207

browse/snapshot_context: Ensure pull request branches can be browsed
ClosedPublic
Actions

Authored by anlambert on Sep 7 2021, 4:22 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSb5ed69554056: browse/snapshot_context: Ensure pull request branches can be browsed

Summary

While pull request branches are hidden by default in Web UI, they should
remain browsable.

That commit fixes the error that was previously raised when attempting
to browse such a branch.

Related sentry issue

Diff Detail

Repository

rDWAPPS Web applications

Branch

fix-browse-pr-branch

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23421
Build 36546: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36545: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 7 2021, 4:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 7 2021, 4:22 PM

Build was aborted

Patch application report for D6207 (id=22470)

Rebasing onto b552b01dc7...

Current branch diff-target is up to date.

Changes applied before test

commit b5ed6955405629ad6469f0e33ce0afec89636f5d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 7 16:18:38 2021 +0200

    browse/snapshot_context: Ensure pull request branches can be browsed
    
    While pull request branches are hidden by default in Web UI, they should
    remain browsable.
    
    That commit fixes the error that was previously raised when attempting
    to browse such a branch.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1089/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1089/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 7 2021, 4:43 PM

Harbormaster failed remote builds in B23421: Diff 22470!

Build is green

Patch application report for D6207 (id=22470)

Rebasing onto b552b01dc7...

Current branch diff-target is up to date.

Changes applied before test

commit b5ed6955405629ad6469f0e33ce0afec89636f5d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 7 16:18:38 2021 +0200

    browse/snapshot_context: Ensure pull request branches can be browsed
    
    While pull request branches are hidden by default in Web UI, they should
    remain browsable.
    
    That commit fixes the error that was previously raised when attempting
    to browse such a branch.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1090/ for more details.

Harbormaster completed remote builds in B23421: Diff 22470.Sep 7 2021, 5:04 PM

anlambert requested review of this revision.Sep 7 2021, 5:04 PM