Always flush kafka producers in tests
ClosedPublic
Actions

Authored by olasd on Jul 21 2021, 3:14 PM.

Details

Reviewers

ardumont

Commits

rDSEA122d7caf6577: Always flush kafka producers in tests

Summary

Sometimes, in a very loaded situation, the producer can return and let
the consumer start before the topic is actually created.

Adding a producer.flush() avoids that race condition.

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 21 2021, 3:14 PM

Build is green

Patch application report for D6016 (id=21729)

Rebasing onto d58705a0eb...

Current branch diff-target is up to date.

Changes applied before test

commit 0a9023b81108244b1ac41e124272a0473f2ff5c3
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jul 21 15:12:49 2021 +0200

    Always flush kafka producers in tests
    
    Sometimes, in a very loaded situation, the producer can return and let
    the consumer start before the topic is actually created.
    
    Adding a `producer.flush()` avoids that race condition.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/223/ for more details.

Harbormaster completed remote builds in B22697: Diff 21729.Jul 21 2021, 3:18 PM

olasd requested review of this revision.Jul 21 2021, 3:18 PM

ardumont accepted this revision.Jul 21 2021, 3:44 PM

This revision is now accepted and ready to land.Jul 21 2021, 3:44 PM

Rebase

Build is green

Patch application report for D6016 (id=21755)

Rebasing onto 4e453304ad...

Current branch diff-target is up to date.

Changes applied before test

commit 122d7caf6577f4090f66e909688178b1e6ce41b1
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jul 21 15:12:49 2021 +0200

    Always flush kafka producers in tests
    
    Sometimes, in a very loaded situation, the producer can return and let
    the consumer start before the topic is actually created.
    
    Adding a `producer.flush()` avoids that race condition.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/231/ for more details.

Harbormaster completed remote builds in B22722: Diff 21755.Jul 23 2021, 10:18 AM

Closed by commit rDSEA122d7caf6577: Always flush kafka producers in tests (authored by olasd). · Explain WhyJul 23 2021, 10:32 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSEA122d7caf6577: Always flush kafka producers in tests.