Differential D6001

cli: Hide traceback when cookers fail
ClosedPublic
Actions

Authored by vlorentz on Jul 16 2021, 2:30 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDVAU7122ef5099c6: cli: Hide traceback when cookers fail

Summary

There is nothing interesting about this traceback because it only
shows frames in the objstorage and the CLI.
The actual error is always printed before with its own traceback
before this one is shown.

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22634
Build 35289: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35288: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	323 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestSnapshotCooker::test_snapshot_tags[cook_extract_snapshot_git_bare] self = <swh.vault.tests.test_cookers.TestSnapshotCooker object at 0x7fafb9f4d198> git_loader = <function git_loader.<locals>._create_loader at 0x7fafb9ff9bf8> cook_extract_snapshot = <function cook_extract_snapshot_git_bare at 0x7fafbbafe840>
	79 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_backend::test_available
	101 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_backend::test_cache_expire_oldest
	120 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_backend::test_cache_expire_until
	96 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_backend::test_cook_email_pending_done
		View Full Test Results (1 Failed · 93 Passed)

Event Timeline

vlorentz created this revision.Jul 16 2021, 2:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2021, 2:30 PM

Build has FAILED

Patch application report for D6001 (id=21661)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..6b1acb5
Fast-forward
 swh/vault/cli.py                |   9 +-
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  94 +++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 4 files changed, 420 insertions(+), 62 deletions(-)

Changes applied before test

commit 6b1acb5b29f193def241b76f795f76c9df9c3b33
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:29:18 2021 +0200

    cli: Hide traceback when cookers fail
    
    There is nothing interesting about this traceback because it only
    shows frames in the objstorage and the CLI.
    The actual error is always printed before with its own traceback
    before this one is shown.

commit c427dd8017062e37dfe0bfdd3113cd0999e30d55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/138/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/138/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2021, 2:32 PM

Harbormaster failed remote builds in B22631: Diff 21661!

rebase

Build has FAILED

Patch application report for D6001 (id=21664)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..e00f805
Fast-forward
 swh/vault/cli.py                |   9 +-
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  94 +++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 4 files changed, 420 insertions(+), 62 deletions(-)

Changes applied before test

commit e00f805570c0d01197c2ead9b7fd6312cb8dbcf0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:29:18 2021 +0200

    cli: Hide traceback when cookers fail
    
    There is nothing interesting about this traceback because it only
    shows frames in the objstorage and the CLI.
    The actual error is always printed before with its own traceback
    before this one is shown.

commit 6c5f0746228febc14b3445451f4645ae46409994
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/141/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/141/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2021, 2:53 PM

Harbormaster failed remote builds in B22634: Diff 21664!

rebase

vlorentz added a child revision: D6002: git_bare: Add support for swh-graph when loading a snapshot.Jul 16 2021, 3:26 PM

Build is green

Patch application report for D6001 (id=21666)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..7122ef5
Fast-forward
 swh/vault/cli.py                |   9 +-
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  94 +++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 4 files changed, 420 insertions(+), 62 deletions(-)

Changes applied before test

commit 7122ef5099c6a1e3be2c28b889122c9c1beb882a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:29:18 2021 +0200

    cli: Hide traceback when cookers fail
    
    There is nothing interesting about this traceback because it only
    shows frames in the objstorage and the CLI.
    The actual error is always printed before with its own traceback
    before this one is shown.

commit 73b2b13b9e06a8bdf5f6ea5d3b526d1e0c53fcf9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/143/ for more details.

Harbormaster completed remote builds in B22636: Diff 21666.Jul 16 2021, 3:29 PM

vlorentz requested review of this revision.Jul 16 2021, 3:29 PM

ardumont accepted this revision.Jul 19 2021, 10:12 AM

This revision is now accepted and ready to land.Jul 19 2021, 10:12 AM

Closed by commit rDVAU7122ef5099c6: cli: Hide traceback when cookers fail (authored by vlorentz). · Explain WhyJul 26 2021, 2:30 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU7122ef5099c6: cli: Hide traceback when cookers fail.