Depends on D5998
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T843: Vault: Add a "git bare" tarball cooker
- Commits
- rDVAU4cb80723d8fb: git_bare: Add partial support for snapshots (no release or swh-graph support…
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D5999 (id=21649)
Could not rebase; Attempt merge onto 5951a5c63b...
Updating 5951a5c..4cb8072 Fast-forward swh/vault/cookers/__init__.py | 1 + swh/vault/cookers/git_bare.py | 66 +++++++-- swh/vault/tests/test_cookers.py | 297 +++++++++++++++++++++++++++++++++------- 3 files changed, 305 insertions(+), 59 deletions(-)
Changes applied before test
commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 15 19:46:54 2021 +0200
git_bare: Add partial support for snapshots (no release or swh-graph support yet)
commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 15 17:20:44 2021 +0200
tests: Split RepoFixtures off TestRevisionCooker
So the 'load' and 'check' parts of the tests can be reused by future
snapshot tests.
commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 15 16:58:55 2021 +0200
tests: Make TestRevisionCooker more modular
So its 'load' and 'check' parts can be reused for testing snapshotsSee https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/135/ for more details.
Comment Actions
lgtm
one question inline about existing term which i'm not sure about though.
| swh/vault/tests/test_cookers.py | ||
|---|---|---|
| 645 | what does ert and p stand for? might be p is for pointer. | |
| swh/vault/tests/test_cookers.py | ||
|---|---|---|
| 645 | I don't know, I'm just copy-pasting | |