Differential D5984

apidoc: Remove explicit recursion used in visit_field_list
ClosedPublic
Actions

Authored by vlorentz on Jul 9 2021, 1:18 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS3bfc6942fe49: apidoc: Remove explicit recursion used in visit_field_list

Summary

The visit is already recursive, we don't need to add this explicit
recursion.

Children nodes can be dispatched to visit_field_name and
visit_field_body instead.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22553
Build 35148: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35147: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 9 2021, 1:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2021, 1:18 PM

Build is green

Patch application report for D5984 (id=21578)

Rebasing onto dd2e5e261b...

Current branch diff-target is up to date.

Changes applied before test

commit 3bfc6942fe497ff28eed722ab7f208cdd1b81110
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 9 13:18:12 2021 +0200

    apidoc: Remove explicit recursion used in visit_field_list
    
    The visit is already recursive, we don't need to add this explicit
    recursion.
    
    Children nodes can be dispatched to visit_field_name and
    visit_field_body instead.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/961/ for more details.

Harbormaster completed remote builds in B22553: Diff 21578.Jul 9 2021, 1:34 PM

vlorentz requested review of this revision.Jul 9 2021, 1:34 PM