Differential D5936

Add an endpoint to list metadata authorities for a given SWHID
ClosedPublic
Actions

Authored by vlorentz on Jun 28 2021, 4:06 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2938: Create API endpoint to access raw_extrinsic_metadata

Commits

rDWAPPS7759503780d7: Add an endpoint to list metadata authorities for a given SWHID

Summary

It allows easier discovery for humans, as clients need to know the authority
type/url to list metadata on a given SWHID.

Test Plan

Tests will fail because they depend on D5934.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22294
Build 34698: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34697: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	647 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_metadata::Tests / Python tests / test_api_raw_extrinsic_metadata_list_authorities api_client = <rest_framework.test.APIClient object at 0x7fee053070f0> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7fee05079b70>
	216 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
	259 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
	122 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
	134 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
		View Full Test Results (1 Failed · 708 Passed · 5 Skipped)

Event Timeline

vlorentz created this revision.Jun 28 2021, 4:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 28 2021, 4:06 PM

vlorentz added a task: T2938: Create API endpoint to access raw_extrinsic_metadata.Jun 28 2021, 4:06 PM

vlorentz edited the test plan for this revision. (Show Details)

Build has FAILED

Patch application report for D5936 (id=21313)

Rebasing onto e18341dd82...

Current branch diff-target is up to date.

Changes applied before test

commit 6a11cd545f0e5509cda7f8eb7cc95d13500c1577
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jun 28 16:05:55 2021 +0200

    Add an endpoint to list metadata authorities for a given SWHID
    
    It allows easier discovery for humans, as clients need to know the authority
    type/url to list metadata on a given SWHID.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/911/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/911/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 28 2021, 4:20 PM

Harbormaster failed remote builds in B22294: Diff 21313!

vlorentz requested review of this revision.Jun 29 2021, 12:18 PM

After clarification of the rationale on IRC, LGTM (with some marginal changes), thanks.

Has storage been tagged with this new endpoint?

swh/web/api/views/metadata.py
205	s/objects/object/ or s/objects/target/
211	s/metadata/metadata-providing authorities/?
226	Needs a trailing slash?
245–247	rolls eyes Thanks black.

This revision is now accepted and ready to land.Jul 5 2021, 4:39 PM

Has storage been tagged with this new endpoint?

Not yet, I was waiting for the green light on this design.

rebase + apply comments + trigger rebuild

Build is green

Patch application report for D5936 (id=21488)

Rebasing onto 3c06b0331d...

Current branch diff-target is up to date.

Changes applied before test

commit 7759503780d7a82e348e3209ef6b3257b7b66992
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jun 28 16:05:55 2021 +0200

    Add an endpoint to list metadata authorities for a given SWHID
    
    It allows easier discovery for humans, as clients need to know the authority
    type/url to list metadata on a given SWHID.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/923/ for more details.

Harbormaster completed remote builds in B22467: Diff 21488.Jul 5 2021, 5:39 PM

Closed by commit rDWAPPS7759503780d7: Add an endpoint to list metadata authorities for a given SWHID (authored by vlorentz). · Explain WhyJul 6 2021, 9:51 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS7759503780d7: Add an endpoint to list metadata authorities for a given SWHID.