Differential D588

flake8: except: pass is evil
ClosedPublic
Actions

Authored by douardda on Oct 24 2018, 4:55 PM.

Tags

None

Subscribers

Details

Reviewers

ardumont
olasd

Group Reviewers

Commits

rDARC0343859f6d73: Fix another flake8 error in checker.py
rDARC0f4f3eb02322: Move logger creation from LogContentChecker to its base class BaseContentChecker

Summary

at least report the exception.

Test Plan

flake8 should not be as grumpy as it used to be

Diff Detail

Repository

rDARC Software Heritage Archiver

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 24 2018, 4:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 24 2018, 4:55 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DARC/job/tox/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DARC/job/tox/9/console

Harbormaster failed remote builds in B1879: Diff 1801!Oct 24 2018, 5:01 PM

ardumont accepted this revision.Oct 24 2018, 5:33 PM

This revision is now accepted and ready to land.Oct 24 2018, 5:33 PM

seirl requested changes to this revision.Oct 24 2018, 5:43 PM

seirl added a subscriber: seirl.

seirl added inline comments.

swh/archiver/checker.py
61	Why not use logging.exception() instead?

This revision now requires changes to proceed.Oct 24 2018, 5:43 PM

rebased

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DARC/job/tox/14/
See console output for more information: https://jenkins.softwareheritage.org/job/DARC/job/tox/14/console

Harbormaster failed remote builds in B1888: Diff 1808!Oct 24 2018, 6:49 PM

ardumont added inline comments.Oct 25 2018, 9:09 AM

swh/archiver/checker.py
61	That'd be more consistent with other locations. Also that'd potentially convey more information if we ever start digging the log errors on that part ;)

morphed into: Move logger creation from LogContentChecker to its base class BaseContentChecker

olasd accepted this revision.Oct 25 2018, 4:58 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DARC/job/tox/17/
See console output for more information: https://jenkins.softwareheritage.org/job/DARC/job/tox/17/console

Harbormaster failed remote builds in B1926: Diff 1841!Oct 25 2018, 4:58 PM

fix forgottent argument to self.logger.exception()

douardda marked 2 inline comments as done.Oct 25 2018, 5:05 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DARC/job/tox/18/
See console output for more information: https://jenkins.softwareheritage.org/job/DARC/job/tox/18/console

Harbormaster failed remote builds in B1927: Diff 1842!Oct 25 2018, 5:05 PM

olasd accepted this revision.Oct 25 2018, 5:08 PM

Fix another flake8 error in checker.py

so jenkins is (hopefully) green

Build is green
See https://jenkins.softwareheritage.org/job/DARC/job/tox/19/ for more details.

Harbormaster completed remote builds in B1928: Diff 1843.Oct 25 2018, 5:16 PM

ardumont accepted this revision.Oct 25 2018, 6:00 PM

ardumont removed a reviewer: seirl.

This revision is now accepted and ready to land.Oct 25 2018, 6:01 PM

so jenkins is (hopefully) green

It is \m/

Closed by commit rDARC0f4f3eb02322: Move logger creation from LogContentChecker to its base class BaseContentChecker (authored by douardda). · Explain WhyOct 29 2018, 10:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

archiver/

23 lines

Diff 1891

swh/archiver/checker.py

Loading...