tests: Add tox.ini and migrate to pytest
ClosedPublic
Actions

Authored by ardumont on Oct 23 2018, 6:58 PM.

Details

Reviewers

douardda
seirl

Commits

rDVAUc58b4841ab3d: tests: Mark tox failing tests and avoid running them for now
rDVAUf696051a63e5: tests: Remove pep8 violations
rDVAUfafe09623446: requirements-tests.txt: Add missing tests dependencies
rDVAU8427f7677db8: tox.ini: Run tests through pifpaf
rDVAU36dc13256ef5: tests: Migrate to pytest
rDVAUd23497d6a2db: tests: Add tox.ini

Summary

Related T1247
Related T1261

Test Plan

tox

This fails, one test is in error

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 23 2018, 6:58 PM

Harbormaster completed remote builds in B1842: Diff 1782.Oct 23 2018, 6:58 PM

douardda accepted this revision.Oct 23 2018, 7:29 PM

This revision is now accepted and ready to land.Oct 23 2018, 7:29 PM

In fact, no, since the test do require a pg setup, tox needs to run them via pifpaf

This revision now requires changes to proceed.Oct 23 2018, 7:31 PM

There also missing test requirements: dulwich and swh.loader.git

These should be added in a commit included in this Diff

huh, right!
I just realize i ran make test instead of tox...

Thanks.

There also missing test requirements: dulwich and swh.loader.git

There is also a runtime dependency on git...
And there is nowhere to define that here.
Except in the debian/control file but i do not touch as this will be reworked pretty soon and that will not solve the problem in that ci's particular job, i think.

Just fixing what's not correct for now

tox.ini: Run tests through pifpaf
requirements-tests.txt: Add missing tests dependencies

Note:
I still need to track db connections issues

Harbormaster failed remote builds in B1849: Diff 1783!Oct 24 2018, 9:38 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tox/6/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tox/6/console

I still need to track db connections issues

~> P322 for details.

I think that's an instance of the issue reported at T826 (not solved yet) about test and implicit loading configuration.
I see some service=swh-dev which is my user configuration...

tests: Remove pep8 violations
tests: Mark tox failing tests and avoid running them for now

ardumont mentioned this in D584: swh.vault.tests: Migrate to swh.model.hashutil.MultiHash.Oct 24 2018, 11:28 AM

Build is green
See https://jenkins.softwareheritage.org/job/DVAU/job/tox/7/ for more details.

Harbormaster completed remote builds in B1851: Diff 1785.Oct 24 2018, 11:29 AM

ardumont mentioned this in T1286: swh-vault: Fix problematic tests in tox environment.Oct 24 2018, 11:34 AM

douardda accepted this revision.Oct 24 2018, 3:49 PM

This revision is now accepted and ready to land.Oct 24 2018, 3:49 PM

Closed by commit rDVAUd23497d6a2db: tests: Add tox.ini (authored by ardumont). · Explain WhyOct 24 2018, 4:00 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a child revision: D584: swh.vault.tests: Migrate to swh.model.hashutil.MultiHash.Oct 25 2018, 3:57 PM