Page MenuHomeSoftware Heritage

swh.model.hashutil: Remove deprecated hash_* function...
ClosedPublic

Authored by ardumont on Oct 25 2018, 1:51 PM.

Details

Summary

...to the benefit of the MultiHash api.

This closes the loop started with the pypi loader which pulled the MultiHash
migration.

Depends on D584
Depends on D595
Depends on D596

Test Plan
  • in that repository: tox
  • in swh-environment: make test

And finally, the following commands no longer reveals those function calls:

$ cd swh-environment
$ grep -ri 'hash_data' | grep -v '.tox' | grep -v '.js' | grep -v 'cache' | grep -v '.html' | grep -v '.git' | grep -v '.txt' | grep -v '.build' | grep 'hash_'
$ grep -ri 'hash_file' | grep -v '.tox' | grep -v '.js' | grep -v 'cache' | grep -v '.html' | grep -v '.git' | grep -v '.txt' | grep -v '.build' | grep 'hash_'
$ grep -ri 'hash_path' | grep -v '.tox' | grep -v '.js' | grep -v 'cache' | grep -v '.html' | grep -v '.git' | grep -v '.txt' | grep -v '.build' | grep 'hash_'

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Oct 25 2018, 3:59 PM
This revision was automatically updated to reflect the committed changes.