Makefile.local: Ensure to kill child processes at devserver target exit
ClosedPublic
Actions

Authored by anlambert on May 25 2021, 4:30 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS21616f563572: Makefile.local: Ensure to kill child processes at devserver target exit

Summary

This change ensure that child processes created by the make target named
run-django-webpack-devserver will always be killed when exiting.

It fixes the issue of webpack related processes still alive when
the django runserver command exits with errors.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 25 2021, 4:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 25 2021, 4:30 PM

Add missing backslash

Build is green

Patch application report for D5782 (id=20668)

Rebasing onto 79c6da6bed...

Current branch diff-target is up to date.

Changes applied before test

commit 8bb7b1f39f8bb4b2b0f07eaddb1c188474181628
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 16:25:44 2021 +0200

    Makefile.local: Ensure to kill child processes at devserver target exit
    
    This change ensure that child processes created by the make target named
    run-django-webpack-devserver will always be killed when exiting.
    
    It fixes the issue of webpack related processes still alive when
    the django runserver command exits with errors.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/845/ for more details.

Harbormaster completed remote builds in B21631: Diff 20668.May 25 2021, 4:48 PM

Build is green

Patch application report for D5782 (id=20674)

Rebasing onto 79c6da6bed...

Current branch diff-target is up to date.

Changes applied before test

commit 21616f5635720ad35931e10092f64f1acae5474d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 16:25:44 2021 +0200

    Makefile.local: Ensure to kill child processes at devserver target exit
    
    This change ensure that child processes created by the make target named
    run-django-webpack-devserver will always be killed when exiting.
    
    It fixes the issue of webpack related processes still alive when
    the django runserver command exits with errors.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/846/ for more details.

Harbormaster completed remote builds in B21638: Diff 20674.May 25 2021, 5:01 PM

anlambert requested review of this revision.May 25 2021, 5:01 PM

ardumont accepted this revision.May 25 2021, 5:18 PM

This revision is now accepted and ready to land.May 25 2021, 5:18 PM

Closed by commit rDWAPPS21616f563572: Makefile.local: Ensure to kill child processes at devserver target exit (authored by anlambert). · Explain WhyMay 25 2021, 6:45 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS21616f563572: Makefile.local: Ensure to kill child processes at devserver target exit.