Page MenuHomeSoftware Heritage

Makefile.local: Ensure to kill child processes at devserver target exit
ClosedPublic

Authored by anlambert on May 25 2021, 4:30 PM.

Details

Summary

This change ensure that child processes created by the make target named
run-django-webpack-devserver will always be killed when exiting.

It fixes the issue of webpack related processes still alive when
the django runserver command exits with errors.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21631
Build 33616: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 33615: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5782 (id=20668)

Rebasing onto 79c6da6bed...

Current branch diff-target is up to date.
Changes applied before test
commit 8bb7b1f39f8bb4b2b0f07eaddb1c188474181628
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 16:25:44 2021 +0200

    Makefile.local: Ensure to kill child processes at devserver target exit
    
    This change ensure that child processes created by the make target named
    run-django-webpack-devserver will always be killed when exiting.
    
    It fixes the issue of webpack related processes still alive when
    the django runserver command exits with errors.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/845/ for more details.

Build is green

Patch application report for D5782 (id=20674)

Rebasing onto 79c6da6bed...

Current branch diff-target is up to date.
Changes applied before test
commit 21616f5635720ad35931e10092f64f1acae5474d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 16:25:44 2021 +0200

    Makefile.local: Ensure to kill child processes at devserver target exit
    
    This change ensure that child processes created by the make target named
    run-django-webpack-devserver will always be killed when exiting.
    
    It fixes the issue of webpack related processes still alive when
    the django runserver command exits with errors.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/846/ for more details.

This revision is now accepted and ready to land.May 25 2021, 5:18 PM