Differential D569

Switch test runner to pytest instead of nose
ClosedPublic
Actions

Authored by olasd on Oct 23 2018, 12:31 PM.

Details

Reviewers

douardda

Maniphest Tasks

T1261: migrate tests from nose to pytest

Commits

rDENV1a40b426547c: Switch test runner to pytest instead of nose

Summary

Also port the coverage flags to be compatible with pytest-cov.

Kinda sorta close T1261.

Test Plan

looks like make test is happy

Diff Detail

Repository

rDENV Development environment

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1760
Build 2121: tox-on-jenkins
Build 2120: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 23 2018, 12:31 PM

Harbormaster failed remote builds in B1760: Diff 1749!Oct 23 2018, 12:31 PM

sounds good.

I'm always wondering what's the difference between using the module and what looks like the executable that is:

python3 -m pytest
pytest (~> in the tox.ini started to get defined here and there e.g in swh-scheduler, that's what's used)

ok, but we loose the --with-doctest, which should be mentioned in the commit msg (I'm wondering if https://github.com/thisch/pytest-sphinx would be useful also)

This revision is now accepted and ready to land.Oct 23 2018, 2:54 PM

In D569#11214, @douardda wrote:

ok, but we loose the --with-doctest, which should be mentioned in the commit msg (I'm wondering if https://github.com/thisch/pytest-sphinx would be useful also)

ACK; I've added the proper setting to the modules that need them.

Closed by commit rDENV1a40b426547c: Switch test runner to pytest instead of nose (authored by olasd). · Explain WhyOct 23 2018, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Makefile.python

8 lines

Diff 1749

View Options

Switch test runner to pytest instead of noseClosedPublicActions