client: Raise GraphArgumentException on 4xx response, instead of generic RemoteException.
ClosedPublic
Actions

Authored by vlorentz on May 4 2021, 12:19 PM.

Details

Reviewers

Group Reviewers

Summary

For consistency with other RPC clients, and because RemoteException is too
generic to be useful (it also covers internal errors of the server, which
can be temporary errors, unlike GraphArgumentException which is for invalid
arguments)

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21239
Build 32976: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32975: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 4 2021, 12:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 4 2021, 12:19 PM

vlorentz added a child revision: D5665: Add a simple alternative "client" in pure-python.May 4 2021, 12:19 PM

Build is green

Patch application report for D5668 (id=20243)

Rebasing onto 1a8b00f4cd...

Current branch diff-target is up to date.

Changes applied before test

commit 2364c7cd2db7f4610adff0fe7452af46a1df778f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 4 12:13:55 2021 +0200

    client: Raise GraphArgumentException on 4xx response, instead of generic RemoteException.
    
    For consistency with other RPC clients, and because RemoteException is too
    generic to be useful (it also covers internal errors of the server, which
    can be temporary errors, unlike GraphArgumentException which is for invalid
    arguments)

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/105/ for more details.

Harbormaster completed remote builds in B21231: Diff 20243.May 4 2021, 12:21 PM

vlorentz requested review of this revision.May 4 2021, 12:21 PM

remove standalone client from the commit

Build is green

Patch application report for D5668 (id=20252)

Rebasing onto 1a8b00f4cd...

Current branch diff-target is up to date.

Changes applied before test

commit 642e8a5468675adcafc1c548abab3650e26289e2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 4 12:13:55 2021 +0200

    client: Raise GraphArgumentException on 4xx response, instead of generic RemoteException.
    
    For consistency with other RPC clients, and because RemoteException is too
    generic to be useful (it also covers internal errors of the server, which
    can be temporary errors, unlike GraphArgumentException which is for invalid
    arguments)

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/110/ for more details.

Harbormaster completed remote builds in B21239: Diff 20252.May 4 2021, 3:06 PM