Page MenuHomeSoftware Heritage

Fix swh-scanner for python 3.7 and >= 3.8
AcceptedPublic

Authored by aastha1999 on Sun, Apr 18, 3:42 PM.

Details

Reviewers
ardumont
vlorentz
Group Reviewers
Reviewers
Summary
  • Include importlib-metadata in requirements.txt for python 3.7
  • Fix swh scanner for python >= 3.8
  • Related T3209

Diff Detail

Repository
rDTSCN Code scanner
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21235
Build 32968: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 32967: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5551 (id=19823)

Rebasing onto 410884067f...

First, rewinding head to replay your work on top of it...
Applying: Fix swh-scanner for python > 3.7
Changes applied before test
commit be5bdeb63ee427f0e088778b4fbfae27e1b7962a
Author: aastha1999 <asthana.aastha1999@gmail.com>
Date:   Sun Apr 18 13:37:55 2021 +0000

    Fix swh-scanner for python > 3.7

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/120/ for more details.

This revision is now accepted and ready to land.Mon, Apr 19, 9:06 AM

From what I understand, the addition of importlib-metadata to requirements.txt is needed to fix python 3.7, not python 3.8.

Please reword your commit message to explain this

This revision now requires changes to proceed.Mon, Apr 19, 11:00 AM

Hey @vlorentz. There were two issues. One was related to python 3.7 and the other was related to >=3.8.

3.7 -> Adding in requirements

3.8 -> swh-scanner -> swh.scanner

Should I change my commit message to Fix swh-scanner for python >=3.7?

Hi, sorry, I missed your reply.

The commit message should explain these are two changes (ideally we would want two commits for that; but a single one is fine here because it is very small).

So something like "Fix swh-scanner for python 3.7 and >= 3.8" on the first line, then explain why the changes are needed in the rest of the message.

  • Change commit message

You accidentally re-added the commit CLI: Add --version, please remove it from the diff.

And please update the diff's title to match the new commit message.

This revision now requires changes to proceed.Tue, May 4, 12:39 PM

Build is green

Patch application report for D5551 (id=20245)

Rebasing onto 30b40cce96...

First, rewinding head to replay your work on top of it...
Applying: CLI: Add --version
Using index info to reconstruct a base tree...
M	swh/scanner/cli.py
Falling back to patching base and 3-way merge...
Auto-merging swh/scanner/cli.py
No changes -- Patch already applied.
Applying: Fix swh-scanner for python 3.7 and >= 3.8
Changes applied before test
commit db53c70ea71a753ee557c40aeb23871f41a8b86c
Author: aastha1999 <asthana.aastha1999@gmail.com>
Date:   Sun Apr 18 13:37:55 2021 +0000

    Fix swh-scanner for python 3.7 and >= 3.8
    
    - Include importlib-metadata in requirements.txt for python 3.7
    - Fix swh scanner for python >= 3.8
    
    :#

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/124/ for more details.

aastha1999 retitled this revision from Fix swh-scanner for python > 3.7 to Fix swh-scanner for python 3.7 and >= 3.8.Tue, May 4, 12:58 PM
aastha1999 edited the summary of this revision. (Show Details)

Build is green

Patch application report for D5551 (id=20247)

Rebasing onto 30b40cce96...

First, rewinding head to replay your work on top of it...
Applying: Fix swh-scanner for python 3.7 and >= 3.8
Changes applied before test
commit bfc61c71b99d22daa58940c80d73a871aafe7bca
Author: aastha1999 <asthana.aastha1999@gmail.com>
Date:   Sun Apr 18 13:37:55 2021 +0000

    Fix swh-scanner for python 3.7 and >= 3.8
    
    - Include importlib-metadata in requirements.txt for python 3.7
    - Fix swh scanner for python >= 3.8

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/125/ for more details.

This revision is now accepted and ready to land.Tue, May 4, 1:28 PM