Differential D5529
Add test to ensure that an exception is raised if unique_key isn't implemented Authored by KShivendu on Apr 14 2021, 8:34 PM.
Details
In-memory Kafka writer didn't have any test. I'm adding a test that ensures that an exception is raised if the object doesn't have a unique_key when passed to the write_addition function. For this, I have passed BaseModel(which doesn't have unique_key implemented) to the write_addition function and I'm checking if it raises a NotImplemented exception. Related T2823
Diff Detail
Event TimelineComment Actions Build is green Patch application report for D5529 (id=19721)Rebasing onto fe820a2220... First, rewinding head to replay your work on top of it... Applying: inmemory: Add test to detect error in object unique_key Changes applied before testcommit c4e8cda26fd8a195945509757371558a915ecd39
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date: Wed Apr 14 23:55:22 2021 +0530
inmemory: Add test to detect error in object unique_keySee https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/154/ for more details. Comment Actions Thanks. One suggestion inline.
Comment Actions oh and actually, there is no reason for this test to be specific to the in-memory implementation. Add it to the regular test suite Comment Actions Build is green Patch application report for D5529 (id=19781)Rebasing onto fe820a2220... First, rewinding head to replay your work on top of it... Applying: test: Catch errors in write_addition if unique_key isn't implemented Changes applied before testcommit 80b533bdd939d2da2370b248b7093d8952a9ce11
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date: Wed Apr 14 23:55:22 2021 +0530
test: Catch errors in write_addition if unique_key isn't implemented
Adding a test that ensures that an exception is raised if the
object passed to write_addition function doesn't have a unique_key.See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/155/ for more details. Comment Actions Build is green Patch application report for D5529 (id=19782)Rebasing onto fe820a2220... Current branch diff-target is up to date. Changes applied before testcommit 236a00262e4f1751cd084d5b80af5885fec13c97
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date: Wed Apr 14 23:55:22 2021 +0530
test: Catch errors in write_addition if unique_key isn't implemented
Adding a test that ensures that an exception is raised if the
object passed to write_addition function doesn't have a unique_key.See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/156/ for more details. Comment Actions
It feels weird adding my name when I've done nothing compared to everyone else. What should I do? Comment Actions
You did contribute this test. | ||||||||||||||||||||||||||