Add the configuration for the source of object counters
ClosedPublic
Actions

Authored by vsellier on Apr 14 2021, 3:05 PM.

Details

Reviewers

ardumont
anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3231: Make the source of the object counts configurable

Commits

rDWAPPS05d55040f31c: Add the configuration for the source of object counters

Summary

Add an option to configure a swh-counters backend
Add an object to choose where to route the counter stats queries

The default behavior is kept as long as the counters_backend property is
not configured

Related to T3231

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20723
Build 32163: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32162: arc lint + arc unit

Event Timeline

vsellier created this revision.Apr 14 2021, 3:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2021, 3:05 PM

Build is green

Patch application report for D5524 (id=19694)

Rebasing onto 6fa50083a1...

Current branch diff-target is up to date.

Changes applied before test

commit 7c52d0a973cab00b251165610b9e2ca3739207bd
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Apr 14 14:55:34 2021 +0200

    Add the configuration for the source of object counters
    
    - Add an option to configure a swh-counters backend
    - Add an object to choose where to route the counter stats queries
    
    The default behavior is kept as long as the counters_backend property is
    not configured
    
    Related to T3231

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/681/ for more details.

Harbormaster completed remote builds in B20723: Diff 19694.Apr 14 2021, 3:12 PM

vsellier requested review of this revision.Apr 14 2021, 3:12 PM

lgtm

one question inline.

@anlambert might want to have a look ;)

swh/web/tests/api/views/test_origin.py
694	are those fixtures?

This revision is now accepted and ready to land.Apr 14 2021, 3:22 PM

Looks good to me.

swh/web/tests/api/views/test_origin.py
694	nope, only backend name here
705	s/object/obj/ to avoid using a python keyword.

rename the object variable

Build is green

Patch application report for D5524 (id=19697)

Rebasing onto 6fa50083a1...

Current branch diff-target is up to date.

Changes applied before test

commit 05d55040f31c1eda327e62a05ae3ef5849eb87f4
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Apr 14 14:55:34 2021 +0200

    Add the configuration for the source of object counters
    
    - Add an option to configure a swh-counters backend
    - Add an object to choose where to route the counter stats queries
    
    The default behavior is kept as long as the counters_backend property is
    not configured
    
    Related to T3231

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/682/ for more details.

Harbormaster completed remote builds in B20726: Diff 19697.Apr 14 2021, 4:20 PM

Closed by commit rDWAPPS05d55040f31c: Add the configuration for the source of object counters (authored by vsellier). · Explain WhyApr 14 2021, 4:23 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDWAPPS05d55040f31c: Add the configuration for the source of object counters.