Page MenuHomeSoftware Heritage

Add the configuration for the source of object counters
ClosedPublic

Authored by vsellier on Apr 14 2021, 3:05 PM.

Details

Summary
  • Add an option to configure a swh-counters backend
  • Add an object to choose where to route the counter stats queries

The default behavior is kept as long as the counters_backend property is
not configured

Related to T3231

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5524 (id=19694)

Rebasing onto 6fa50083a1...

Current branch diff-target is up to date.
Changes applied before test
commit 7c52d0a973cab00b251165610b9e2ca3739207bd
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Apr 14 14:55:34 2021 +0200

    Add the configuration for the source of object counters
    
    - Add an option to configure a swh-counters backend
    - Add an object to choose where to route the counter stats queries
    
    The default behavior is kept as long as the counters_backend property is
    not configured
    
    Related to T3231

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/681/ for more details.

ardumont added subscribers: anlambert, ardumont.

lgtm

one question inline.

@anlambert might want to have a look ;)

swh/web/tests/api/views/test_origin.py
693

are those fixtures?

This revision is now accepted and ready to land.Apr 14 2021, 3:22 PM

Looks good to me.

swh/web/tests/api/views/test_origin.py
693

nope, only backend name here

704

s/object/obj/ to avoid using a python keyword.

Build is green

Patch application report for D5524 (id=19697)

Rebasing onto 6fa50083a1...

Current branch diff-target is up to date.
Changes applied before test
commit 05d55040f31c1eda327e62a05ae3ef5849eb87f4
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Apr 14 14:55:34 2021 +0200

    Add the configuration for the source of object counters
    
    - Add an option to configure a swh-counters backend
    - Add an object to choose where to route the counter stats queries
    
    The default behavior is kept as long as the counters_backend property is
    not configured
    
    Related to T3231

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/682/ for more details.