Differential D5519

urls: Remove trailing slash in SWHID resolving URL
ClosedPublic
Actions

Authored by anlambert on Apr 14 2021, 11:35 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3234: Handle gracefully trailing slashes when resolving SWHID in search box

Commits

rDWAPPS1fde4999ff7b: urls: Remove trailing slash in SWHID resolving URL

Summary

It enables to avoid getting an invalid SWHID when removing the
URL prefix.

Related to T3234#63107

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 14 2021, 11:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2021, 11:35 AM

Build is green

Patch application report for D5519 (id=19684)

Rebasing onto 6fa50083a1...

Current branch diff-target is up to date.

Changes applied before test

commit 057c403a0feed8bb9d6f0bde569c69a46b7ada6d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 14 11:31:54 2021 +0200

    urls: Remove trailing slash in SWHID resolving URL
    
    It enables to avoid getting an invalid SWHID when removing the
    URL prefix.
    
    Related to T3234

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/678/ for more details.

Harbormaster completed remote builds in B20713: Diff 19684.Apr 14 2021, 11:42 AM

anlambert requested review of this revision.Apr 14 2021, 11:42 AM

ardumont accepted this revision.Apr 15 2021, 9:04 AM

This revision is now accepted and ready to land.Apr 15 2021, 9:04 AM

Great!

Rebase

Build is green

Patch application report for D5519 (id=19749)

Rebasing onto 5d74b78688...

Current branch diff-target is up to date.

Changes applied before test

commit 1fde4999ff7b0b350e248c177e9dfdceefd04754
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 14 11:31:54 2021 +0200

    urls: Remove trailing slash in SWHID resolving URL
    
    It enables to avoid getting an invalid SWHID when removing the
    URL prefix.
    
    Related to T3234

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/687/ for more details.

Harbormaster completed remote builds in B20767: Diff 19749.Apr 15 2021, 11:33 AM

Closed by commit rDWAPPS1fde4999ff7b: urls: Remove trailing slash in SWHID resolving URL (authored by anlambert). · Explain WhyApr 15 2021, 12:00 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS1fde4999ff7b: urls: Remove trailing slash in SWHID resolving URL.