Differential D5456

docs: Replace 'deposit storage' terminology; it's confusing
ClosedPublic
Actions

Authored by vlorentz on Apr 8 2021, 3:17 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP7d0f64f2dd0a: docs: Replace 'deposit storage' terminology; it's confusing

Summary

It has nothing to do with swh-storage.

The terminology also implies it's somehow 'smart', but it only refers
to the database. (or to the deposit server itself in authentication.rst)

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 8 2021, 3:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2021, 3:17 PM

Build is green

Patch application report for D5456 (id=19498)

Rebasing onto ab85694f2f...

Current branch diff-target is up to date.

Changes applied before test

commit a65c8b2f7cc8f0957a07e8ec716273b7197d67fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 15:17:18 2021 +0200

    docs: Replace 'deposit storage' terminology; it's confusing
    
    It has nothing to do with swh-storage.
    
    The terminology also implies it's somehow 'smart', but it only refers
    to the database. (or to the deposit server itself in authentication.rst)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/621/ for more details.

Harbormaster completed remote builds in B20539: Diff 19498.Apr 8 2021, 3:20 PM

vlorentz requested review of this revision.Apr 8 2021, 3:20 PM

Mostly ok, one sentence phrasing sounds wrong to me. Please, adapt prior to push this.

docs/internals/authentication.rst
14	the sentence phrasing is wrong here.

This revision is now accepted and ready to land.Apr 8 2021, 4:47 PM

fix typo

This revision was landed with ongoing or failed builds.Apr 8 2021, 5:04 PM

Closed by commit rDDEP7d0f64f2dd0a: docs: Replace 'deposit storage' terminology; it's confusing (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP7d0f64f2dd0a: docs: Replace 'deposit storage' terminology; it's confusing.

Build is green

Patch application report for D5456 (id=19516)

Rebasing onto ab85694f2f...

Current branch diff-target is up to date.

Changes applied before test

commit 7d0f64f2dd0a9336dbeabf80f0b9da30ab29dd10
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 15:17:18 2021 +0200

    docs: Replace 'deposit storage' terminology; it's confusing
    
    It has nothing to do with swh-storage.
    
    The terminology also implies it's somehow 'smart', but it only refers
    to the database. (or to the deposit server itself in authentication.rst)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/627/ for more details.

Harbormaster completed remote builds in B20553: Diff 19516.Apr 8 2021, 5:06 PM