Page MenuHomeSoftware Heritage

docs: Replace 'deposit storage' terminology; it's confusing
ClosedPublic

Authored by vlorentz on Apr 8 2021, 3:17 PM.

Details

Summary

It has nothing to do with swh-storage.

The terminology also implies it's somehow 'smart', but it only refers
to the database. (or to the deposit server itself in authentication.rst)

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20539
Build 31878: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 31877: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5456 (id=19498)

Rebasing onto ab85694f2f...

Current branch diff-target is up to date.
Changes applied before test
commit a65c8b2f7cc8f0957a07e8ec716273b7197d67fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 15:17:18 2021 +0200

    docs: Replace 'deposit storage' terminology; it's confusing
    
    It has nothing to do with swh-storage.
    
    The terminology also implies it's somehow 'smart', but it only refers
    to the database. (or to the deposit server itself in authentication.rst)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/621/ for more details.

ardumont added a subscriber: ardumont.

Mostly ok, one sentence phrasing sounds wrong to me. Please, adapt prior to push this.

docs/internals/authentication.rst
15

the sentence phrasing is wrong here.

This revision is now accepted and ready to land.Apr 8 2021, 4:47 PM
This revision was landed with ongoing or failed builds.Apr 8 2021, 5:04 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D5456 (id=19516)

Rebasing onto ab85694f2f...

Current branch diff-target is up to date.
Changes applied before test
commit 7d0f64f2dd0a9336dbeabf80f0b9da30ab29dd10
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 15:17:18 2021 +0200

    docs: Replace 'deposit storage' terminology; it's confusing
    
    It has nothing to do with swh-storage.
    
    The terminology also implies it's somehow 'smart', but it only refers
    to the database. (or to the deposit server itself in authentication.rst)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/627/ for more details.