Page MenuHomeSoftware Heritage

HgLoaderFromDisk: Stop reading/writing Revision.metadata
ClosedPublic

Authored by vlorentz on Tue, Apr 6, 2:44 PM.

Details

Summary

It already writes it with raw_extrinsic_metadata_add/extid_add,
and read it with extid_get_*.

This code was only kept for compatibility while we were migrating
the extids. This is now done, so this code is useless.

Partially resolves T3139 and T3138

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5424 (id=19384)

Rebasing onto d35b2692b5...

Current branch diff-target is up to date.
Changes applied before test
commit 15389dca90d612265a6fc183e2231187d2635a05
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 6 14:40:50 2021 +0200

    HgLoaderFromDisk: Stop reading/writing Revision.metadata
    
    It already writes it with raw_extrinsic_metadata_add/extid_add,
    and read it with extid_get_*.
    
    This code was only kept for compatibility while we were migrating
    the extids. This is now done, so this code is useless.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/199/ for more details.

This revision is now accepted and ready to land.Tue, Apr 6, 2:49 PM