HgLoaderFromDisk: Stop reading/writing Revision.metadata
ClosedPublic
Actions

Authored by vlorentz on Apr 6 2021, 2:44 PM.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T3138: Make loaders stop writing in the 'metadata' column of the 'revision' table
T3139: Make loaders stop reading from the 'metadata' column of the 'revision' table

Commits

rDLDHG15389dca90d6: HgLoaderFromDisk: Stop reading/writing Revision.metadata

Summary

It already writes it with raw_extrinsic_metadata_add/extid_add,
and read it with extid_get_*.

This code was only kept for compatibility while we were migrating
the extids. This is now done, so this code is useless.

Partially resolves T3139 and T3138

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20441
Build 31726: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31725: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 6 2021, 2:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 6 2021, 2:44 PM

Build is green

Patch application report for D5424 (id=19384)

Rebasing onto d35b2692b5...

Current branch diff-target is up to date.

Changes applied before test

commit 15389dca90d612265a6fc183e2231187d2635a05
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 6 14:40:50 2021 +0200

    HgLoaderFromDisk: Stop reading/writing Revision.metadata
    
    It already writes it with raw_extrinsic_metadata_add/extid_add,
    and read it with extid_get_*.
    
    This code was only kept for compatibility while we were migrating
    the extids. This is now done, so this code is useless.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/199/ for more details.

Harbormaster completed remote builds in B20441: Diff 19384.Apr 6 2021, 2:46 PM

vlorentz requested review of this revision.Apr 6 2021, 2:46 PM