In a future commit, we will need to go through all the PackageInfo
objects before running the loop, so we can get their ExtID and
fetch them from the storage.
So, we need to fetch them all before running the load loop,
using this listcomp.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3140: Make loaders use ExtId to find what artifacts are already loaded, in addition to revision.metadata
- Commits
- rDLDBASE78430078cd26: package.loader: Unnest loops in PackageLoader.load()
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20239 Build 31412: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 31411: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5345 (id=19157)
Rebasing onto 6d3545e47b...
Current branch diff-target is up to date.
Changes applied before test
commit 78430078cd2647e09cc9a0c09a9e6179d4a0d8b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 23 16:14:42 2021 +0100
package.loader: Unnest loops in PackageLoader.load()
In a future commit, we will need to go through all the PackageInfo
objects before running the loop, so we can get their ExtID and
fetch them from the storage.
So, we need to fetch them all before running the load loop,
using this listcomp.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/439/ for more details.