Page MenuHomeSoftware Heritage

package.loader: Unnest loops in PackageLoader.load()
ClosedPublic

Authored by vlorentz on Mar 25 2021, 7:21 PM.

Details

Summary

In a future commit, we will need to go through all the PackageInfo
objects before running the loop, so we can get their ExtID and
fetch them from the storage.

So, we need to fetch them all before running the load loop,
using this listcomp.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5345 (id=19157)

Rebasing onto 6d3545e47b...

Current branch diff-target is up to date.
Changes applied before test
commit 78430078cd2647e09cc9a0c09a9e6179d4a0d8b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 23 16:14:42 2021 +0100

    package.loader: Unnest loops in PackageLoader.load()
    
    In a future commit, we will need to go through all the PackageInfo
    objects before running the loop, so we can get their ExtID and
    fetch them from the storage.
    
    So, we need to fetch them all before running the load loop,
    using this listcomp.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/439/ for more details.

This revision is now accepted and ready to land.Mar 25 2021, 7:52 PM