Page MenuHomeSoftware Heritage

Rename resolve_revision_from with _artifacts suffix, and fix its documentation
ClosedPublic

Authored by vlorentz on Mar 25 2021, 7:21 PM.

Details

Summary

A future commit will introduce resolve_revision_from_extid, so this commit
preemptively renames it to avoid any confusion.

Depends on D5345

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5346 (id=19158)

Could not rebase; Attempt merge onto 6d3545e47b...

Updating 6d3545e..2f9b8a8
Fast-forward
 swh/loader/package/debian/loader.py              |  4 +-
 swh/loader/package/debian/tests/test_debian.py   | 36 +++++++-----
 swh/loader/package/loader.py                     | 72 ++++++++++++------------
 swh/loader/package/nixguix/tests/test_nixguix.py |  6 +-
 swh/loader/package/tests/test_loader.py          | 10 ++--
 5 files changed, 69 insertions(+), 59 deletions(-)
Changes applied before test
commit 2f9b8a8b1eecb578cdcbe9046262b6087a6c15de
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Mar 25 10:47:03 2021 +0100

    Rename resolve_revision_from with _artifacts suffix, and fix its documentation
    
    A future commit will introduce resolve_revision_from_extid, so this commit
    preemptively renames it to avoid any confusion.

commit 78430078cd2647e09cc9a0c09a9e6179d4a0d8b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 23 16:14:42 2021 +0100

    package.loader: Unnest loops in PackageLoader.load()
    
    In a future commit, we will need to go through all the PackageInfo
    objects before running the loop, so we can get their ExtID and
    fetch them from the storage.
    
    So, we need to fetch them all before running the load loop,
    using this listcomp.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/440/ for more details.

This revision is now accepted and ready to land.Mar 25 2021, 7:42 PM