Switch anonymized replayer test to use pytest parametrization
ClosedPublic
Actions

Authored by olasd on Feb 16 2021, 5:05 PM.

Details

Reviewers

ardumont
anlambert

Commits

rDSTOcc3eb4b175b4: Switch anonymized replayer test to use pytest parametrization

Summary

This allows us to only read the kafka topics once instead of twice in
the same tests, which is apparently a hard thing to do in a way
compatible with both confluent-kafka 1.5 and 1.6.

Test Plan

tested in tox with both confluent-kafka 1.5.0 and 1.6.0

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Feb 16 2021, 5:05 PM

Make the inline comments truthful

Build is green

Patch application report for D5085 (id=18152)

Rebasing onto e0e88b2f57...

Current branch diff-target is up to date.

Changes applied before test

commit 90e48a53c6d382e1e9c45dbe64630e035add9e7d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Feb 16 17:02:43 2021 +0100

    Switch anonymized replayer test to use pytest parametrization
    
    This allows us to only read the kafka topics once instead of twice in
    the same tests, which is apparently a hard thing to do in a way
    compatible with both confluent-kafka 1.5 and 1.6.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1154/ for more details.

Harbormaster completed remote builds in B19256: Diff 18152.Feb 16 2021, 5:10 PM

ardumont mentioned this in T3053: Unstuck swh.storage debian build.Feb 16 2021, 5:15 PM

Build is green

Patch application report for D5085 (id=18153)

Rebasing onto e0e88b2f57...

Current branch diff-target is up to date.

Changes applied before test

commit cc3eb4b175b4c14527a03e9a0fb2391aaf07ca9e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Feb 16 17:02:43 2021 +0100

    Switch anonymized replayer test to use pytest parametrization
    
    This allows us to only read the kafka topics once instead of twice in
    the same tests, which is apparently a hard thing to do in a way
    compatible with both confluent-kafka 1.5 and 1.6.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1155/ for more details.

Harbormaster completed remote builds in B19257: Diff 18153.Feb 16 2021, 5:16 PM

olasd requested review of this revision.Feb 16 2021, 5:16 PM

ardumont accepted this revision.Feb 16 2021, 5:16 PM

This revision is now accepted and ready to land.Feb 16 2021, 5:16 PM

Closed by commit rDSTOcc3eb4b175b4: Switch anonymized replayer test to use pytest parametrization (authored by olasd). · Explain WhyFeb 16 2021, 5:17 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTOcc3eb4b175b4: Switch anonymized replayer test to use pytest parametrization.