Differential D5019

storage.postgresql: Use origin_visit_status.type value as source
ClosedPublic
Actions

Authored by ardumont on Feb 4 2021, 5:41 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2968: Migrate origin_visit_status records to add the type value

Commits

rDSTO046fe57c15f3: storage.postgresql: Use origin_visit_status.type value as source

Summary

This stops using the origin_visit.type as fallback values as now, the database has been
migrated.

So this makes the origin_visit_status.type a not nullable column.

This also drops now redundant join instructions on origin_visit table when reading.

Related to T2968

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 4 2021, 5:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 4 2021, 5:41 PM

ardumont added a child revision: D5020: db: Unify sql joins on origin_visit_status using "USING".Feb 4 2021, 5:41 PM

Build is green

Patch application report for D5019 (id=17896)

Rebasing onto 9a9f234e0a...

Current branch diff-target is up to date.

Changes applied before test

commit 3ad3ac12d46285bb1befd91806f4986b74da7812
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1126/ for more details.

Harbormaster completed remote builds in B19015: Diff 17896.Feb 4 2021, 5:45 PM

ardumont requested review of this revision.Feb 4 2021, 5:45 PM

vlorentz accepted this revision.Feb 5 2021, 9:53 AM

This revision is now accepted and ready to land.Feb 5 2021, 9:53 AM

Rebase

Build was aborted

Patch application report for D5019 (id=17909)

Rebasing onto efd8815b89...

Current branch diff-target is up to date.

Changes applied before test

commit 67bc71ddd9d59a21fb4e5270f29d9cb67d0f711a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1131/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1131/console

Harbormaster failed remote builds in B19028: Diff 17909!Feb 5 2021, 11:35 AM

Build was aborted

Patch application report for D5019 (id=17909)

Rebasing onto efd8815b89...

Current branch diff-target is up to date.

Changes applied before test

commit 67bc71ddd9d59a21fb4e5270f29d9cb67d0f711a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1134/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1134/console

Build was aborted

unrelated to the diff and unknown reason for now.

Rebase

Build is green

Patch application report for D5019 (id=18007)

Rebasing onto 51df58e82e...

Current branch diff-target is up to date.

Changes applied before test

commit 046fe57c15f39e0f94cfbbb46c644a782833281c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1151/ for more details.

Harbormaster completed remote builds in B19127: Diff 18007.Feb 9 2021, 5:26 PM

Closed by commit rDSTO046fe57c15f3: storage.postgresql: Use origin_visit_status.type value as source (authored by ardumont). · Explain WhyFeb 9 2021, 5:28 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO046fe57c15f3: storage.postgresql: Use origin_visit_status.type value as source.