Drop no longer swh.lister.core.{indexing,page_by_page}_lister
ClosedPublic
Actions

Authored by ardumont on Jan 27 2021, 3:46 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLS461bf0997317: Drop no longer swh.lister.core.{indexing,page_by_page}_lister

Summary

The listers depending on it got ported to the new lister api.

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18815
Build 29143: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29142: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 27 2021, 3:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 27 2021, 3:46 PM

Build is green

Patch application report for D4955 (id=17675)

Rebasing onto e09ad272d7...

Current branch diff-target is up to date.

Changes applied before test

commit 461bf0997317b9800d620ee6ac4e409aecc9a378
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 27 15:19:09 2021 +0100

    Drop no longer swh.lister.core.{indexing,page_by_page}_lister
    
    The listers depending on it got ported to the new lister api.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/199/ for more details.

Harbormaster completed remote builds in B18815: Diff 17675.Jan 27 2021, 3:49 PM

ardumont requested review of this revision.Jan 27 2021, 3:49 PM

anlambert accepted this revision.Jan 27 2021, 3:54 PM

This revision is now accepted and ready to land.Jan 27 2021, 3:54 PM

Closed by commit rDLS461bf0997317: Drop no longer swh.lister.core.{indexing,page_by_page}_lister (authored by ardumont). · Explain WhyJan 27 2021, 3:56 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS461bf0997317: Drop no longer swh.lister.core.{indexing,page_by_page}_lister.

@anlambert, thanks, jsyk, i'm working on fixing failing test in the chroot debian in the end goal to deploy the listers in staging.

In D4955#124737, @ardumont wrote:

@anlambert, thanks, jsyk, i'm working on fixing failing test in the chroot debian in the end goal to deploy the listers in staging.

Ack, looks like the python3-pytest-mock package dependency is missing in debian/control.