It enables to pass a phabricator forge base URL as lister parameter.
Phabricator API endpoint URL for listing repositories will then be
constructed from it when instantiating the lister.
Details
Details
- Reviewers
vlorentz olasd - Group Reviewers
Reviewers - Commits
- rDLSd691c04eb80f: phabricator: Allow to pass forge base URL as lister parameter
Diff Detail
Diff Detail
- Repository
- rDLS Listers
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D4863 (id=17227)
Rebasing onto c782275296...
Current branch diff-target is up to date.
Changes applied before test
commit 65c90c6aeac7163039c79bd55b2141da3e1e1984
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Jan 14 13:50:48 2021 +0100
phabricator: Allow to pass forge base URL as lister parameterSee https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/88/ for more details.
Comment Actions
Build is green
Patch application report for D4863 (id=17228)
Rebasing onto c782275296...
Current branch diff-target is up to date.
Changes applied before test
commit 85b7e1cd364592da5f7cf171a63beaa321b3d824
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Jan 14 13:50:48 2021 +0100
phabricator: Allow to pass forge base URL as lister parameterSee https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/89/ for more details.
Comment Actions
Build is green
Patch application report for D4863 (id=17230)
Rebasing onto c782275296...
Current branch diff-target is up to date.
Changes applied before test
commit 9ef56c0aaad5eb5c69296872d61d0ba54ed0cacd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Jan 14 13:50:48 2021 +0100
phabricator: Allow to pass forge base URL as lister parameterSee https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/91/ for more details.
Comment Actions
Build is green
Patch application report for D4863 (id=17232)
Rebasing onto c782275296...
Current branch diff-target is up to date.
Changes applied before test
commit 370a04dbf23a8ecc78af438bb1f066630a7b3d8d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Jan 14 13:50:48 2021 +0100
phabricator: Allow to pass forge base URL as lister parameterSee https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/93/ for more details.
Comment Actions
I made the changes backward compatible with previous URL passed as parameter (see test).
So no migration should be needed here.
Comment Actions
This seems like a very sensible change.
Would you mind adding some documentation for the arguments to this lister in a followup diff?
Comment Actions
Build is green
Patch application report for D4863 (id=17266)
Rebasing onto c782275296...
Current branch diff-target is up to date.
Changes applied before test
commit c5652905952a55afee31dfc126b73e05534de43d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Jan 14 13:50:48 2021 +0100
phabricator: Allow to pass forge base URL as lister parameterSee https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/104/ for more details.
Comment Actions
Build is green
Patch application report for D4863 (id=17302)
Rebasing onto d1fbccd988...
Current branch diff-target is up to date.
Changes applied before test
commit d691c04eb80f3f70906fc2e61e19ef057cc312ba
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Jan 14 13:50:48 2021 +0100
phabricator: Allow to pass forge base URL as lister parameterSee https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/112/ for more details.