Differential D4816

misc/origin_save: Improve save requests page retrieval performance
ClosedPublic
Actions

Authored by anlambert on Jan 6 2021, 6:27 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSd06554a85fb5: misc/origin_save: Improve save requests page retrieval performance

Summary

Improve the overall performance when one wants to display a specific page of
the save code now requests list by:

Applying possibly costly operations (like finding the visit date) only on the save requests to display (the whole list was considered previously)
Implementing search feature using Django model instead of pure Python

Also add missing tests.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18205
Build 28099: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28098: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 6 2021, 6:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 6 2021, 6:27 PM

Build is green

Patch application report for D4816 (id=17065)

Rebasing onto 917b46684b...

Current branch diff-target is up to date.

Changes applied before test

commit d06554a85fb53d5b2121ddeb68fd55b5ba28e7c1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jan 6 18:21:25 2021 +0100

    misc/origin_save: Improve save requests page retrieval performance
    
    Improve the overall performance when one wants to display a specific page of
    the save code now requests list by:
    
      - Applying possibly costly operations (like finding the visit date) only on
        the save requests to display (the whole list was considered previously)
    
      - Implementing search feature using Django model instead of pure Python
    
    Also add missing tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/545/ for more details.

Harbormaster completed remote builds in B18205: Diff 17065.Jan 6 2021, 6:34 PM

anlambert requested review of this revision.Jan 6 2021, 6:34 PM

anlambert mentioned this in T2891: "Save code now" may fail with "OperationalError: database is locked".Jan 6 2021, 6:49 PM

vlorentz accepted this revision.Jan 7 2021, 10:57 AM

This revision is now accepted and ready to land.Jan 7 2021, 10:57 AM

Closed by commit rDWAPPSd06554a85fb5: misc/origin_save: Improve save requests page retrieval performance (authored by anlambert). · Explain WhyJan 7 2021, 11:41 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd06554a85fb5: misc/origin_save: Improve save requests page retrieval performance.