Page MenuHomeSoftware Heritage

misc/origin_save: Improve save requests page retrieval performance
ClosedPublic

Authored by anlambert on Wed, Jan 6, 6:27 PM.

Details

Summary

Improve the overall performance when one wants to display a specific page of
the save code now requests list by:

  • Applying possibly costly operations (like finding the visit date) only on the save requests to display (the whole list was considered previously)
  • Implementing search feature using Django model instead of pure Python

Also add missing tests.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4816 (id=17065)

Rebasing onto 917b46684b...

Current branch diff-target is up to date.
Changes applied before test
commit d06554a85fb53d5b2121ddeb68fd55b5ba28e7c1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jan 6 18:21:25 2021 +0100

    misc/origin_save: Improve save requests page retrieval performance
    
    Improve the overall performance when one wants to display a specific page of
    the save code now requests list by:
    
      - Applying possibly costly operations (like finding the visit date) only on
        the save requests to display (the whole list was considered previously)
    
      - Implementing search feature using Django model instead of pure Python
    
    Also add missing tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/545/ for more details.

This revision is now accepted and ready to land.Thu, Jan 7, 10:57 AM