Differential D4550

requirements-test.txt: Explicit swh.core[db] as test requirement
ClosedPublic
Actions

Authored by ardumont on Nov 20 2020, 5:25 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2746: packaging: Split swh.core and test dependencies properly

Commits

rDLS2e9bb5388b67: requirements-test.txt: Explicit swh.core[db] as test requirement

Summary

instead of pytest-postgresql which is a transitive dependency from swh.core[db]

Related to T2746

Same as D4548 D4549

(That still needs some work on the debian front)

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17347
Build 26796: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26795: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 20 2020, 5:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2020, 5:25 PM

Build is green

Patch application report for D4550 (id=16148)

Rebasing onto 884585034b...

Current branch diff-target is up to date.

Changes applied before test

commit 2e9bb5388b67eb8b673e73de664aa56e5621aebf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:26:25 2020 +0100

    requirements-test.txt: Explicit swh.core[db] as test requirement
    
    instead of pytest-postgresql which is a transitive dependency from swh.core[db]
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/67/ for more details.

Harbormaster completed remote builds in B17347: Diff 16148.Nov 20 2020, 5:29 PM

douardda accepted this revision.Nov 23 2020, 12:44 PM

This revision is now accepted and ready to land.Nov 23 2020, 12:44 PM

This one is actually ok as is (no swh.core[db] in requirements-swh.txt)

Closed by commit rDLS2e9bb5388b67: requirements-test.txt: Explicit swh.core[db] as test requirement (authored by ardumont). · Explain WhyNov 23 2020, 1:14 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS2e9bb5388b67: requirements-test.txt: Explicit swh.core[db] as test requirement.