Differential D4549

requirements-test.txt: Drop no longer needed pytest-postgresql requirement
ClosedPublic
Actions

Authored by ardumont on Nov 20 2020, 5:24 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2746: packaging: Split swh.core and test dependencies properly

Commits

rDSTOe289593f2242: requirements-test.txt: Drop no longer needed pytest-postgresql requirement

Summary

requirements-swh.txt already declares the swh.core[db] dependency which
transitively pulls it.

Related to T2746

(That still needs some work on the debian front)

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 20 2020, 5:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2020, 5:24 PM

ardumont mentioned this in D4550: requirements-test.txt: Explicit swh.core[db] as test requirement.Nov 20 2020, 5:25 PM

ardumont edited the summary of this revision. (Show Details)Nov 20 2020, 5:26 PM

Build is green

Patch application report for D4549 (id=16147)

Rebasing onto 0065d4df13...

First, rewinding head to replay your work on top of it...
Applying: requirements-test.txt: Explicit swh.core[db] as test requirement

Changes applied before test

commit cd2fe638ec10b15460eacd09ebf4ae3cb3a522ea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:25:27 2020 +0100

    requirements-test.txt: Explicit swh.core[db] as test requirement
    
    instead of pytest-postgresql which is a transitive dependency from swh.core[db]
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1069/ for more details.

Harbormaster completed remote builds in B17346: Diff 16147.Nov 20 2020, 5:29 PM

Actually drop that requirements

Build is green

Patch application report for D4549 (id=16183)

Rebasing onto 0065d4df13...

Current branch diff-target is up to date.

Changes applied before test

commit e289593f2242d652716b47e7f7ed19097688dc4c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:25:27 2020 +0100

    requirements-test.txt: Drop no longer needed pytest-postgresql requirement
    
    requirements-swh.txt already declares the swh.core[db] dependency which
    transitively pulls it.
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1070/ for more details.

Harbormaster completed remote builds in B17383: Diff 16183.Nov 23 2020, 1:14 PM

ardumont retitled this revision from requirements-test.txt: Explicit swh.core[db] as test requirement to requirements-test.txt: Drop no longer needed pytest-postgresql requirement.Nov 23 2020, 1:23 PM

ardumont edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2020, 1:24 PM

Closed by commit rDSTOe289593f2242: requirements-test.txt: Drop no longer needed pytest-postgresql requirement (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOe289593f2242: requirements-test.txt: Drop no longer needed pytest-postgresql requirement.