Page MenuHomeSoftware Heritage

test_client: Add a step to update the partial deposit with archive
ClosedPublic

Authored by ardumont on Oct 9 2020, 4:09 PM.

Details

Summary

This should actually cover all the missing cases now.

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16133
Build 24819: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24818: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4221 (id=14899)

Could not rebase; Attempt merge onto b18cd89d4c...

Updating b18cd89d..419c1b26
Fast-forward
 swh/deposit/tests/cli/test_client.py               | 230 ++++++++++++++-------
 .../https_deposit.test.metadata/1_test_666_media   |   1 +
 .../https_deposit.test.status/1_servicedocument    |  26 +++
 .../https_deposit.test.status/1_test_1033_status   |  10 +
 4 files changed, 187 insertions(+), 80 deletions(-)
 create mode 120000 swh/deposit/tests/data/https_deposit.test.metadata/1_test_666_media
 create mode 100644 swh/deposit/tests/data/https_deposit.test.status/1_servicedocument
 create mode 100644 swh/deposit/tests/data/https_deposit.test.status/1_test_1033_status
Changes applied before test
commit 419c1b26d0452bc9965ed01c29ce6c1ab5c50831
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 16:10:21 2020 +0200

    test_client: Add a step to update the partial deposit with archive
    
    This should actually cover all the missing cases now.

commit 1a782449064a4228af12ad768862611cc5a49a69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 13:48:49 2020 +0200

    test_client: Add scenario on deposit status cli
    
    This also checks the 3 different format outputs which were not so far.

commit 404f2728ad0f85789b0827025eafb1c8b6124c05
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 9 12:17:58 2020 +0200

    test_client: Refactor and simplify tests for a better readability
    
    This:
    - Align all tests to use json format so the output check is simpler
    - Simplify the failure cases to check the caplog record
    - Drop dead code
    - Rename tests with a `test_cli_` prefix so it's simpler to run separately from
    the rest

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/200/ for more details.

This revision is now accepted and ready to land.Oct 9 2020, 5:26 PM