Page MenuHomeSoftware Heritage

backfill: use the common `storage` top-level config key
ClosedPublic

Authored by olasd on Thu, Oct 8, 9:00 PM.

Details

Summary

This makes the backfiller configuration compatible with all other modules.

Depends on D4209

Test Plan

tox tests updated

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Thu, Oct 8, 9:00 PM

Build is green

Patch application report for D4210 (id=14844)

Could not rebase; Attempt merge onto a6af589ada...

Updating a6af589a..a085b7ec
Fast-forward
 swh/storage/backfill.py            | 16 +++++++++-------
 swh/storage/tests/test_backfill.py | 20 ++++++++++++--------
 2 files changed, 21 insertions(+), 15 deletions(-)
Changes applied before test
commit a085b7ec6edeeaa52b144e0022578f70093f7d9b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 20:34:35 2020 +0200

    backfill: use the common `storage` top-level config key
    
    This makes the backfiller configuration compatible with all other modules.

commit dceeb7443c7fc8361586ffdccadb10cdfc10a9a1
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 18:32:35 2020 +0200

    backfill: support arbitrary journal writer configuration
    
    This allows more settings than the previous hardcoded three, e.g. the
    `privileged` flag to backfill a journal containing anonymous topics.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1002/ for more details.

douardda accepted this revision.Fri, Oct 9, 4:34 PM

same

This revision is now accepted and ready to land.Fri, Oct 9, 4:34 PM
This revision was automatically updated to reflect the committed changes.