Page MenuHomeSoftware Heritage

backfill: support arbitrary journal writer configuration
ClosedPublic

Authored by olasd on Thu, Oct 8, 8:59 PM.

Details

Summary

This allows more settings than the previous hardcoded three, e.g. the
privileged flag to backfill a journal containing anonymous topics.

Test Plan

tox tests updated

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4209 (id=14843)

Rebasing onto a6af589ada...

Current branch diff-target is up to date.
Changes applied before test
commit dceeb7443c7fc8361586ffdccadb10cdfc10a9a1
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 18:32:35 2020 +0200

    backfill: support arbitrary journal writer configuration
    
    This allows more settings than the previous hardcoded three, e.g. the
    `privileged` flag to backfill a journal containing anonymous topics.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1001/ for more details.

douardda accepted this revision.Fri, Oct 9, 4:33 PM

oh so much yes!

This revision is now accepted and ready to land.Fri, Oct 9, 4:33 PM
This revision was automatically updated to reflect the committed changes.