Page MenuHomeSoftware Heritage

Fix license statements on db_utils.py
ClosedPublic

Authored by olasd on Sep 18 2020, 2:41 PM.

Details

Summary

When the code was migrated from swh.storage, some other ancillary functions were
merged into this file. So bits of it are under the LGPLv3 (the code pulled from
psycopg2) and bits are under the GPLv3 (the code we wrote).

Test Plan

only comment shuffling

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3987 (id=14058)

Rebasing onto 28d61c8cf1...

Current branch diff-target is up to date.
Changes applied before test
commit b63d7f432caeb9d75da6151fb20f3764beec7f80
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Sep 18 14:39:50 2020 +0200

    Fix license statements on db_utils.py
    
    When the code was migrated from swh.storage, some other ancillary functions were
    merged into this file. So bits of it are under the LGPLv3 (the code pulled from
    psycopg2) and bits are under the GPLv3 (the code we wrote).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/63/ for more details.

This is fine, and better than the status quo.
(We should in theory also mention the other applicable copyright notices at the beginning of the file, but we weren't doing that before either, so this change LGTM.)

This revision is now accepted and ready to land.Sep 19 2020, 8:13 PM
This revision was automatically updated to reflect the committed changes.